Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lets bedsheets be put over things #30027

Closed
wants to merge 1 commit into from

Conversation

Doritodude77
Copy link

@Doritodude77 Doritodude77 commented Jul 14, 2024

About the PR

Changes the drawdepth of bedsheets so that people can actually sleep under them. SS14 isn't minecraft, so no more sleeping on top of your bed! This change also lets you cover small objects with blankets, and even larger ones if you have enough of them.
Just like the real thing!

Why / Balance

I thought it was odd that everyone sleeps on top of beds, so I fixed it.

Technical details

Added drawdepth: OverMobs

Media

untitled.mp4
  • [X ] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog
🆑

  • tweak: You can now sleep under bedsheets, which can also hide things.

Changes the drawdepth of bedsheets so that people can actually sleep under them. SS14 isn't minecraft, so no more sleeping on top of your bed!
This change also lets you cover small objects with sheets, and even larger ones if you have enough of them. Just like the real thing!
@github-actions github-actions bot added the Changes: No C# Changes: Requires no C# knowledge to review or fix this item. label Jul 14, 2024
@lzk228
Copy link
Contributor

lzk228 commented Jul 14, 2024

they shouldnt always be like that, only on beds

@TeenSarlacc
Copy link
Contributor

nobody expects the ol' minibomb+c4 under the blanket trick

@luizwritescode
Copy link
Contributor

I imagine bedsheets would then be hassle for doctor's trying to treat someone, maybe have them draw like that only when someone is sleeping in bed?

@Doritodude77
Copy link
Author

Doritodude77 commented Jul 16, 2024

they shouldnt always be like that, only on beds

It can't work like that, the only technical correlation between a bed and a blanket is the grid they're both initially placed on

@TheShuEd
Copy link
Member

It looks great, but it opens up too much scope for hiding things or creatures. Simply switching the rendering layer will cause more problems than it will help. A more comprehensive solution is needed.

@TheShuEd TheShuEd closed this Jul 17, 2024
@TeenSarlacc
Copy link
Contributor

It looks great, but it opens up too much scope for hiding things or creatures.

I'd love to get killed by a spider hiding under a blanket lmao

@Doritodude77
Copy link
Author

It looks great, but it opens up too much scope for hiding things or creatures. Simply switching the rendering layer will cause more problems than it will help. A more comprehensive solution is needed.

That's not a problem, that's a bonus that most importantly would have always existed IRL!
The fact that I can think "I should hide this under a blanket" and not be able to is a problem in itself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: No C# Changes: Requires no C# knowledge to review or fix this item.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants