fix(RequireProjectileTargetSystem): Add ent invalid check. #30015
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A situation can happen where shooter.value references entity 0. Check for that and treat it like it's null.
github-actions
bot
added
the
S: Needs Review
Comment on lines
31
to
35
| { | ||
| // Prevents shooting out of while inside of crates | ||
| var shooter = projectile.Shooter; | ||
| if (!shooter.HasValue) | ||
| if (!shooter.HasValue || shooter.Value == EntityUid.Invalid) | ||
| return; |
There was a problem hiding this comment.
Do you know why this entityid is invalid?
There was a problem hiding this comment.
I don't have a repo for this and it was on live. I assume the HasValue was intended to be checked for EntityUid.Invalid as well. This code is new within the last month or so. If you have ideas on how to debug live running games let me know, ideally with a debugger.
There was a problem hiding this comment.
I'm not even sure if shooter can even be false for HasValue since Invalid is a Value.
SlamBamActionman
added
the
S: Untriaged
eoineoineoin
added
T: Bugfix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
A situation can happen where shooter.value references entity 0. Check for that and treat it like it's null.