Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update HideMechanismsCommand.cs #30006

Closed
wants to merge 3 commits into from
Closed

Conversation

Errant-4
Copy link
Member

@Errant-4 Errant-4 commented Jul 13, 2024

About the PR

Remove/update Obsolete code

Why / Balance

Project 0 Warning

Technical details

Changed TryGetContainingContainer to a supported version
Updated locale stuff for this command and the related showmechanisms command

@lzk228
Copy link
Contributor

lzk228 commented Jul 13, 2024

would be good if you included standartized desc and help like in #29945
it inherits LocalizedCommands for a reason

@Errant-4
Copy link
Member Author

would be good if you included standartized desc and help like in #29945 it inherits LocalizedCommands for a reason

Good point, thanks

@github-actions github-actions bot added the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Aug 4, 2024
Copy link
Contributor

github-actions bot commented Aug 4, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@Errant-4 Errant-4 closed this Aug 26, 2024
@Errant-4 Errant-4 deleted the hidemech branch August 26, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants