Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SmartEquip now Pulls the Gun/Light Rather than the Magazine/Battery #29986

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

SmartEquip now Pulls the Gun/Light Rather than the Magazine/Battery #29986

wants to merge 5 commits into from
+17 −2

Conversation

Cojoke-dot
Copy link
Contributor

@Cojoke-dot Cojoke-dot commented Jul 13, 2024 •
edited
Loading

About the PR

When storing a gun on your backslot or beltslot, when using Smart-Equip it takes out the gun rather than the magazine of the weapon.

Why / Balance

It does not make much sense to me to pull the magazine of a weapon on your belt rather than the weapon itself...

Technical details

Check if the item being pulled from does has the SmartEquipItemSlotComponent before trying to take an item out of the inventory

Media

2024-07-13.01-34-39.mp4
  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

🆑

  • tweak: Smart-Equip now takes the gun or light out of the slot rather than the items inventory.

@lzk228
Copy link
Contributor

lzk228 commented Jul 13, 2024

does it also works with lantern in belt slot?

@Cojoke-dot
Copy link
Contributor Author

ok... is there anything else that is like that? Don't want batteries or mags drawn from a smart-Equip... I don't know what else is like that

@Cojoke-dot Cojoke-dot changed the title SmartEquip now Pulls the Gun Rather than the Magazine SmartEquip now Pulls the Gun/Light Rather than the Magazine/Battery Jul 14, 2024
@SlamBamActionman SlamBamActionman added the S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. label Nov 14, 2024
@eoineoineoin eoineoineoin added T: Bugfix Type: Bugs and/or bugfixes S: Needs Review Status: Requires additional reviews before being fully accepted DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. A: General Interactions Area: General in-game interactions that don't relate to another area. P3: Standard Priority: Default priority for repository items. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzk228 lzk228 lzk228 left review comments

@metalgearsloth metalgearsloth metalgearsloth requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
A: General Interactions Area: General in-game interactions that don't relate to another area. DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. P3: Standard Priority: Default priority for repository items. S: Needs Review Status: Requires additional reviews before being fully accepted T: Bugfix Type: Bugs and/or bugfixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Cojoke-dot @lzk228 @metalgearsloth @eoineoineoin @SlamBamActionman