Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add review exemption for minor bugfixes #382

Merged
merged 2 commits into from
Jan 15, 2025

Conversation

SlamBamActionman
Copy link
Member

As discussed internally within the maintainer team, this exemption allows a single maintainer to merge/close minor bugfixes, bypassing the "2 Maintainer" requirement.

@K-Dynamic
Copy link

K-Dynamic commented Jan 15, 2025

What happens if the PR has a content bundled with bug fix, or art asset/respriting with bug fix

@ArtisticRoomba
Copy link

What happens if the PR has a content bundled with bug fix, or art asset/respriting with bug fix

as per PR guidelines these should be atomized into separate PRs for easier review and managing already

@SlamBamActionman
Copy link
Member Author

Exemptions are also optional; while there may be edgecases, we put some trust into maintainers exercising common sense whether an exemption is warranted. And with the biweekly release review we have an additional safety net to catch things before release.

@Errant-4
Copy link
Member

And with the biweekly release review we have an additional safety net to catch things before release.

Although, now that I think about it, a PR that accidentally slipped through as a Bugfix might likewise slip through the feature list, which does not include bugfixes. We will just have to be vigilant about the list, I guess

@PJB3005 PJB3005 merged commit 80bf8b6 into space-wizards:master Jan 15, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants