Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add no rp speak in the pr guidlines #157

Merged
merged 6 commits into from
Feb 9, 2024

Conversation

VasilisThePikachu
Copy link
Member

We (try) to enforce it. May as well make sure its in here to be enforced.

@Errant-4
Copy link
Member

Errant-4 commented Feb 8, 2024

I uh, I must point out that you did not end either of the "Good" examples with a . and thus fail our CL guidelines

Funny changelogs will always live on in my heart but you do have a point, this is the way forward now

@VasilisThePikachu
Copy link
Member Author

I uh, I must point out that you did not end either of the "Good" examples with a . and thus fail our CL guidelines

Funny changelogs will always live on in my heart but you do have a point, this is the way forward now

bruh

@BasedUser
Copy link

BasedUser commented Feb 8, 2024

good these make sense

Copy link
Contributor

@Partmedia Partmedia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see this as part of "be concise", because RP-speak obfuscates what actually changed. But I'm happy with this change as well. Leaving open in case you want to copy edit a bit. It would be good to explain why you shouldn't use "RP speak", and the reason is it conflicts with "be concise" and to the point.

@VasilisThePikachu
Copy link
Member Author

I see this as part of "be concise", because RP-speak obfuscates what actually changed. But I'm happy with this change as well. Leaving open in case you want to copy edit a bit. It would be good to explain why you shouldn't use "RP speak", and the reason is it conflicts with "be concise" and to the point.

"be concise" is a pretty weird wording to use for it. I will just play it safe and keep it separate unless someone who knows english can word it better

@Partmedia Partmedia merged commit e97a178 into space-wizards:master Feb 9, 2024
2 checks passed
@Partmedia
Copy link
Contributor

I've made some edits and merged. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants