-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add no rp speak in the pr guidlines #157
Conversation
I uh, I must point out that you did not end either of the "Good" examples with a . and thus fail our CL guidelines Funny changelogs will always live on in my heart but you do have a point, this is the way forward now |
bruh |
good these make sense |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see this as part of "be concise", because RP-speak obfuscates what actually changed. But I'm happy with this change as well. Leaving open in case you want to copy edit a bit. It would be good to explain why you shouldn't use "RP speak", and the reason is it conflicts with "be concise" and to the point.
"be concise" is a pretty weird wording to use for it. I will just play it safe and keep it separate unless someone who knows english can word it better |
I've made some edits and merged. Thanks. |
We (try) to enforce it. May as well make sure its in here to be enforced.