New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MRG: provide default failed filenames based on CSV #195

Merged

ctb merged 8 commits into main from default_fail_out

Jan 28, 2025

Contributor

ctb commented Jan 26, 2025

Fixes #192

--failed defaults to os.path.basename(csv_file).fail.txt, and --checksum-fail defaults to os.path.basename(csv_file).checksum_fail.txt.

ctb added 2 commits

January 25, 2025 17:20


          MRG: provide default failed filenames based on CSV

d4e0e09


          add tests

Contributor Author

ctb commented Jan 26, 2025

ready for review & merge @bluegenes!

bluegenes reviewed

View reviewed changes

src/python/sourmash_plugin_directsketch/__init__.py Outdated Show resolved Hide resolved

bluegenes reviewed

View reviewed changes

src/python/sourmash_plugin_directsketch/__init__.py Outdated Show resolved Hide resolved

bluegenes reviewed

View reviewed changes

tests/test_gbsketch.py Outdated Show resolved Hide resolved

bluegenes reviewed

View reviewed changes

tests/test_urlsketch.py Outdated Show resolved Hide resolved

bluegenes reviewed

View reviewed changes

tests/test_urlsketch.py Outdated Show resolved Hide resolved

bluegenes requested changes

View reviewed changes

Collaborator

bluegenes left a comment

thanks @ctb, this is great. I think the file extensions should be .csv, since they are csv files, right?

ctb and others added 5 commits

January 28, 2025 07:38


          Update src/python/sourmash_plugin_directsketch/__init__.py

0c97e04

Co-authored-by: Tessa Pierce Ward <[email protected]>


          Update src/python/sourmash_plugin_directsketch/__init__.py

158020d

Co-authored-by: Tessa Pierce Ward <[email protected]>


          Update tests/test_gbsketch.py

ab8db1e

Co-authored-by: Tessa Pierce Ward <[email protected]>


          Update tests/test_urlsketch.py

2b8cc48

Co-authored-by: Tessa Pierce Ward <[email protected]>


          Update tests/test_urlsketch.py

9c8f141

Co-authored-by: Tessa Pierce Ward <[email protected]>

Contributor Author

ctb commented Jan 28, 2025

thanks @ctb, this is great. I think the file extensions should be .csv, since they are csv files, right?

yep!


          Merge branch 'main' of github.com:sourmash-bio/sourmash_plugin_direct…

224505c

…sketch into default_fail_out

bluegenes approved these changes

View reviewed changes

Collaborator

bluegenes left a comment

great! 🎉

ctb merged commit ba5d26d into main

1 check passed

ctb deleted the default_fail_out branch

January 28, 2025 20:03

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet