-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MRG: remove BuildParams
, filter via manifest / Select
approaches
#127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BuildParams
, filter manifest directlyBuildParams
, filter manifest via Select
approach
BuildParams
, filter manifest via Select
approachBuildParams
, filter via manifest / Select
approaches
BuildParams
, filter via manifest / Select
approachesBuildParams
, filter via manifest / Select
approaches
@ctb ready for review. This restructure happened because I was doing some manual hashing of |
ctb
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the
BuildParams
manual hashing + filtering with manifest filtering and selection (e.g. of moltypes) via aSelect
framework. This is more in tune with the approaches in sourmash core. I did addMultiSelect
here, since we want to keep all templates that match sets of selection parameters.Internal improvements to the framework introduced in 0.4.0:
BuildParams
/BuildParamsSet
is now inBuildRecord
/BuildCollection
. We now parse the parameter string directly into aBuildCollection
, rather than going throughBuildParams
as an intermediary.BuildCollection
directly viaMultiSelect
, e.g. for moltype filtering. We can also filter a manifest with another manifest by using PartialEq forBuildRecord
s. This replaces the prior approach of keeping aBuildParamsSet
and hashingBuildParams
manually for comparisons.ComputeParameters
to actually build template signatures.ComputeParameters
instead ofBuildParams
#113