Repository navigation
Conversation
Contributor
A maintainer will review your pull requestSourcey can't admit this change automatically, so a maintainer reviews it. You don't need to do anything. Follow your pull request on Sourcey ! A maintainer reviews this change.
|
… in the body The guide told contributors to leave out an interface that is GraphQL alone. Only a second interface that is GraphQL inside a self-hosted product is left out; a public GraphQL API answers the probe like any JSON API, and leaving out a vendor's only interface would grade it F. A gRPC call is declared with the application/grpc body format. Where the vendor takes its key in the request body, the operation's body names that field, since OpenAPI cannot state such a key as a security scheme. Signed-off-by: Kam <oss@0state.com>
auscaster
force-pushed
the
docs/readiness-grpc-graphql
branch
from
October 12, 2026 10:10
bdcd71f to
6acb7a7
Compare
Contributor
A maintainer will review your pull requestSourcey can't admit this change automatically, so a maintainer reviews it. You don't need to do anything. Follow your pull request on Sourcey ! A maintainer reviews this change.
|
Member
Author
|
Folded into #394, which carries this change with the other CONTRIBUTING updates so they land in one review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three corrections to the listing guide, matching Catalog's contract (verifier 1.1.27):
application/grpcbody format: a POST to the method's path, e.g./modal.client.ModalClient/SandboxCreate.{ media_type: application/json, credential_field: api_key }, as Amplitude's does. OpenAPI has no security scheme for a key in the body, so without this the vendor's own document can't say the request needs one.