Add support for multi-modal moderation inputs and category applied input types #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iBotPeaches
requested changes
Apr 28, 2025
tests/Resources/Moderations.php
Outdated
Comment on lines
48
to
61
| test('create omni', closure: function () { | ||
| $client = mockClient('POST', 'moderations', [ | ||
| 'model' => 'omni-moderation-latest', | ||
| 'input' => 'I want to kill them.', | ||
| 'input' => [ | ||
| ['type' => 'text', 'text' => '.. I want to kill...'], | ||
| ], | ||
| ], Response::from(moderationOmniResource(), metaHeaders())); | ||
|
|
||
| $result = $client->moderations()->create([ | ||
| 'model' => 'omni-moderation-latest', | ||
| 'input' => 'I want to kill them.', | ||
| 'input' => [ | ||
| ['type' => 'text', 'text' => '.. I want to kill...'], | ||
| ], | ||
| ]); |
There was a problem hiding this comment.
This should probably support both right? We need to support the string legacy option as well as array of multi-modal
There was a problem hiding this comment.
@iBotPeaches Yes, It support both. Should I revert this changes and create new unit test ?
There was a problem hiding this comment.
I just want to make sure both work. You changed both of them to the multi-modal approach. We should probably have:
- A basic text only test
- A basic text & image test
- A basic text in array test
iBotPeaches
reviewed
Apr 28, 2025
|
Looks good. Please open this PR upstream on the main repo for the other maintainers. So repeat yourself a bit in the description of the PR to remind why we are adding this. Don't leak any clients though. |
|
Merged upstream - openai-php@62e9822 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Description:
Related: