Skip to content

Noise reduction #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: base-sha/31a8b26b476e48da22269d88f6379fea1e934491
Choose a base branch
from
Open

Noise reduction #67

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ RUN micromamba install -y -n base -f /tmp/environment.yml && \

ARG MAMBA_DOCKERFILE_ACTIVATE=1
WORKDIR /app
# This is the arrdn filter model hogwash for ffmpeg noise reduction
copy sh.rnnn /app
COPY ttt.py /app

ENTRYPOINT ["/usr/local/bin/_entrypoint.sh", "python","-u","/app/ttt.py" ]
22 changes: 22 additions & 0 deletions sh.rnnn
View file
Open in desktop

Large diffs are not rendered by default.

6 changes: 3 additions & 3 deletions ttt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,14 +230,14 @@ def audio_notification(audiofile, apobj, body, title):
"-y",
"-i",
audiofile,
"-filter:a",
"-af",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue (bug_risk): Duplicate '-af' filter option in ffmpeg command.

The '-af' option is specified twice which might lead to unexpected behavior or errors. Verify if this duplication is intentional and necessary.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this comment correct?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this comment helpful?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the comment type correct?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the comment area correct?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this comment become an LLM test?

"arnndn=m='/app/sh.rnnn'",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (testing): Missing test for the new noise reduction filter

The PR introduces a new noise reduction filter in the audio processing command. It's crucial to add a test to verify that the filter is applied correctly and effectively reduces noise without affecting other audio properties.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this comment correct?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this comment helpful?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the comment type correct?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the comment area correct?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this comment become an LLM test?

"-af",
"loudnorm=i=-14",
"-ar",
"8000",
"-c:a",
"aac",
"-b",
"8000",
aacfile,
]
subprocess.run(ffmpeg_cmd, check=True, capture_output=True)
Expand Down