Skip to content

Add ar #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: base-sha/ef85e439747bc9b1c64c6c2781ef241b39cb0895
Choose a base branch
from
Open

Add ar #63

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ttt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,6 +232,8 @@ def audio_notification(audiofile, apobj, body, title):
audiofile,
"-filter:a",
"loudnorm=i=-14",
"-ar",
"8000",
Comment on lines +235 to +236
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (performance): Consider the impact of the audio sample rate change on audio quality and file size.

Setting the audio sample rate to 8000 Hz might significantly reduce the audio quality. Ensure this trade-off is acceptable for the application's requirements. Additionally, consider if this lower sample rate could lead to smaller file sizes, which might be beneficial or detrimental depending on the context.

Suggested change
"-ar",
"8000",
"-ar",
"16000",

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this comment correct?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this comment helpful?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the comment type correct?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the comment area correct?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this comment become an LLM test?

"-c:a",
"aac",
"-b",
Expand Down