Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Benchmark Index (community)
Details
| Benchmark suite | Current: 99b2dec | Previous: d0e79df | Ratio |
|---|---|---|---|
Add one schema (0 existing) |
227 ms |
159 ms |
1.43 |
Add one schema (100 existing) |
22 ms |
19 ms |
1.16 |
Add one schema (1000 existing) |
74 ms |
65 ms |
1.14 |
Add one schema (10000 existing) |
631 ms |
844 ms |
0.75 |
Update one schema (1 existing) |
15 ms |
13 ms |
1.15 |
Update one schema (101 existing) |
21 ms |
19 ms |
1.11 |
Update one schema (1001 existing) |
73 ms |
66 ms |
1.11 |
Update one schema (10001 existing) |
628 ms |
710 ms |
0.88 |
Cached rebuild (1 existing) |
4 ms |
4 ms |
1 |
Cached rebuild (101 existing) |
6 ms |
6 ms |
1 |
Cached rebuild (1001 existing) |
25 ms |
24 ms |
1.04 |
Cached rebuild (10001 existing) |
238 ms |
218 ms |
1.09 |
Index 100 schemas |
111 ms |
83 ms |
1.34 |
Index 1000 schemas |
872 ms |
777 ms |
1.12 |
Index 10000 schemas |
12643 ms |
15657 ms |
0.81 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Benchmark Index (enterprise)
Details
| Benchmark suite | Current: 99b2dec | Previous: d0e79df | Ratio |
|---|---|---|---|
Add one schema (0 existing) |
187 ms |
174 ms |
1.07 |
Add one schema (100 existing) |
18 ms |
18 ms |
1 |
Add one schema (1000 existing) |
57 ms |
57 ms |
1 |
Add one schema (10000 existing) |
485 ms |
785 ms |
0.62 |
Update one schema (1 existing) |
14 ms |
13 ms |
1.08 |
Update one schema (101 existing) |
18 ms |
17 ms |
1.06 |
Update one schema (1001 existing) |
59 ms |
56 ms |
1.05 |
Update one schema (10001 existing) |
491 ms |
474 ms |
1.04 |
Cached rebuild (1 existing) |
4 ms |
4 ms |
1 |
Cached rebuild (101 existing) |
5 ms |
5 ms |
1 |
Cached rebuild (1001 existing) |
17 ms |
17 ms |
1 |
Cached rebuild (10001 existing) |
158 ms |
221 ms |
0.71 |
Index 100 schemas |
100 ms |
91 ms |
1.10 |
Index 1000 schemas |
742 ms |
802 ms |
0.93 |
Index 10000 schemas |
10776 ms |
10431 ms |
1.03 |
This comment was automatically generated by workflow using github-action-benchmark.
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
🤖 Augment PR SummarySummary: This PR implements MCP 🤖 Was this summary useful? React with 👍 or 👎 |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 13 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="enterprise/server/action_mcp_v1.cc">
<violation number="1" location="enterprise/server/action_mcp_v1.cc:184">
P2: Build resource URIs from `registry_url` (the base used by resources/read) instead of the CORS `allowed_origin`, otherwise listed URIs can’t be resolved when those values differ.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
| #include <algorithm> // std::ranges::transform | ||
| #include <cassert> // assert | ||
| #include <cctype> // std::tolower | ||
| #include <charconv> // std::from_chars |
There was a problem hiding this comment.
test
Severity: low
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
| result.assign_assume_new( | ||
| std::string{"nextCursor"}, | ||
| sourcemeta::core::JSON{std::to_string(next_schema_offset)}); | ||
| } |
There was a problem hiding this comment.
enterprise/server/action_mcp_v1.cc — schema_offset + MCP_PAGE_SCHEMAS can overflow for extremely large (but valid) cursor values, potentially producing a wrapped nextCursor.
That could create surprising pagination behavior (e.g., empty page with a non-empty next cursor).
Severity: medium
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
| #include <algorithm> // std::ranges::transform | ||
| #include <cassert> // assert | ||
| #include <cctype> // std::tolower | ||
| #include <charconv> // std::from_chars |
There was a problem hiding this comment.
(Meta) Please ignore the previous "test" inline comment at this location; it was an accidental placeholder while validating review anchors.
Severity: low
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
1 participant
Signed-off-by: Juan Cruz Viotti jv@jviotti.com