Skip to content

style(clang-tidy): fix misc-use-anonymous-namespace #1699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 20, 2025
Merged

style(clang-tidy): fix misc-use-anonymous-namespace #1699

merged 4 commits into from
Jun 20, 2025

Conversation

bavulapati
Copy link
Contributor

fixes #1678

@jviotti
Copy link
Member

jviotti commented May 26, 2025

Looks generally good, but keep in mind that when you use the anonymous namespace, you should also remove the static qualifiers for each of the helper functions

@bavulapati
Copy link
Contributor Author

Looks generally good, but keep in mind that when you use the anonymous namespace, you should also remove the static qualifiers for each of the helper functions

Thanks for catching it. It's either static or anonymous namespace.

@bavulapati
Copy link
Contributor Author

@jviotti Do you have any comments on this PR?

jviotti
jviotti reviewed Jun 19, 2025
View reviewed changes
jviotti
jviotti reviewed Jun 19, 2025
View reviewed changes
jviotti
jviotti reviewed Jun 19, 2025
View reviewed changes
@jviotti
Copy link
Member

jviotti commented Jun 19, 2025

Sorry for the delay. I added a few more comments!

@jviotti
Copy link
Member

jviotti commented Jun 19, 2025

From what I can see, this specific commit is missing the sign-off

Screenshot 2025-06-19 at 13 56 31

bavulapati and others added 3 commits June 20, 2025 10:15
@bavulapati
style(clang-tidy): fix misc-use-anonymous-namespace
ce57772 
fixes sourcemeta#1678

Signed-off-by: Balakrishna Avulapati <[email protected]>
@bavulapati
remove static specifier
798ac5a 
Signed-off-by: Balakrishna Avulapati <[email protected]>
@bavulapati
use single anonymous namespace for the file
4c62a4e 
Signed-off-by: Balakrishna Avulapati <[email protected]>
@bavulapati bavulapati force-pushed the fix-misc-use-anonymous-namespace branch from b5c5b63 to 4c62a4e Compare June 20, 2025 04:48
@bavulapati
run clang format
12b5d71 
Signed-off-by: Balakrishna Avulapati <[email protected]>
@bavulapati
Copy link
Contributor Author

@jviotti Addressed comments. PTAL

jviotti
jviotti approved these changes Jun 20, 2025
View reviewed changes
Copy link
Member

@jviotti jviotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@jviotti jviotti merged commit a9de30f into sourcemeta:main Jun 20, 2025
14 checks passed
@bavulapati bavulapati deleted the fix-misc-use-anonymous-namespace branch June 20, 2025 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jviotti jviotti jviotti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ClangTidy warnings for misc-use-anonymous-namespace
2 participants
@bavulapati @jviotti