Skip to content

style(clang-tidy): fix cppcoreguidelines init variables #1698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 19, 2025
Merged

style(clang-tidy): fix cppcoreguidelines init variables #1698

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/core/json/json_value.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,7 +359,7 @@ auto JSON::operator-=(const JSON &substractive) -> JSON & {
return false;
} else if (this->is_real()) {
const auto value{this->to_real()};
Real integral;
Real integral = 0.0;
return !std::isinf(value) && !std::isnan(value) &&
std::modf(value, &integral) == 0.0;
} else {
Expand Down Expand Up @@ -659,14 +659,14 @@ JSON::at(const String &key,
const auto dividend_value{this->as_real()};

// Every real number that represents an integral is divisible by 0.5.
Real dividend_integral;
Real dividend_integral = 0;
if (std::modf(dividend_value, &dividend_integral) == 0.0 &&
divisor_value == 0.5) {
return true;
}

const auto division{dividend_value / divisor_value};
Real integral;
Real integral = 0;
return !std::isinf(division) && !std::isnan(division) &&
std::modf(division, &integral) == 0.0;
}
Expand Down
4 changes: 2 additions & 2 deletions src/core/uri/uri.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ static auto uri_normalize(UriUriA *uri) -> void {
}

static auto uri_to_string(const UriUriA *const uri) -> std::string {
int size;
int size = 0;
if (uriToStringCharsRequiredA(uri, &size) != URI_SUCCESS) {
throw sourcemeta::core::URIError{"Could not determine URI size"};
}
Expand Down Expand Up @@ -48,7 +48,7 @@ static auto uri_text_range(const UriTextRangeA *const range)
}

static auto uri_parse(const std::string &data, UriUriA *uri) -> void {
const char *error_position;
const char *error_position = nullptr;
switch (uriParseSingleUriA(uri, data.c_str(), &error_position)) {
case URI_ERROR_SYNTAX:
// TODO: Test the positions of this error
Expand Down