Skip to content
This repository was archived by the owner on Oct 16, 2020. It is now read-only.

fix(logging): do not use JSON.stringify to Error object #666

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Milly
Copy link

@Milly Milly commented Mar 14, 2020

the result of JSON.stringify(new Error('msg')) is {}.
pass the Error object to logger as it is.

the result of `JSON.stringify(new Error('msg'))` is `{}`.
pass the `Error` object to logger as it is.
@codecov-io
Copy link

codecov-io commented Mar 14, 2020

Codecov Report

Merging #666 into master will increase coverage by 0.18%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #666      +/-   ##
==========================================
+ Coverage   82.40%   82.59%   +0.18%     
==========================================
  Files          15       15              
  Lines        2126     2126              
  Branches      509      448      -61     
==========================================
+ Hits         1752     1756       +4     
+ Misses        364      360       -4     
  Partials       10       10              
Impacted Files Coverage Δ
src/plugins.ts 90.90% <100.00%> (+6.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd893d2...5a663b4. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants