-
Notifications
You must be signed in to change notification settings - Fork 250
enhance: support tools installed via flatpak #1517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
I suggest directly creating a command-line tool for
|
Digging deeper, it looks like Flatpak already does this for me! Specifying the following install path works for my per-user Meld installation: |
5563305
to
cf819b8
Compare
I've updated this PR with much cleaner Flatpak external tool support based on inspecting the system-wide and per-user If sourcegit can have special support for JetBrains Toolbox then it seems reasonable that it can also support Flatpak on Linux. |
It's because this is a cross-platform app, and there are so many JetBrains products (currently we support 16 JetBrains products), and their installation paths vary on different platforms. Also, different versions can coexist. To solve the startup problem, JetBrains itself provides the JetBrains Toolbox. This is not exactly the same as third-party package managers like Flatpak. |
I agree with everything you've said. |
05dba32
to
6822ae3
Compare
072502a
to
5ce919a
Compare
This PR is a bit experimental.
I have various tools installed via Flatpak (Meld, VSCodium, etc) that I'd like sourcegit to integrate with. Currently all diff and merge tools must resolve to a known binary file, whereas Flatpak apps are launched via the flatpak binary (eg
flatpak run org.gnome.meld
). I've figured out some workarounds to getExternalTool
andExternalMerger
working but I'm reluctant to make any significant changes because I can only test on Linux.