feat: Ask Sourcebot #392
feat: Ask Sourcebot #392
Conversation
…ecific lines of code.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
♻️ Duplicate comments (2)
packages/web/src/app/[domain]/chat/components/chatSidePanel.tsx (1)
236-236: Make keyboard shortcut hint platform-aware.The keyboard shortcut hint is hardcoded as "⌘ B" but should display the appropriate modifier key based on the user's platform since the actual hotkey uses "mod+b".
This issue was previously identified in past reviews. Consider implementing a platform detection utility or updating the
KeyboardShortcutHintcomponent to accept "mod+b" and render the correct symbol automatically.packages/web/src/features/chat/components/chatThread/codeFoldingExtension.ts (1)
244-303: Add cleanup for React roots to prevent memory leaks.The React root created in
toDOMis never unmounted, which could lead to memory leaks when widgets are destroyed.
🧹 Nitpick comments (2)
packages/web/src/features/chat/components/chatThread/answerCard.tsx (1)
27-84: Consider extracting toast messages as constants.The implementation is solid. For better maintainability, consider extracting the toast messages as constants.
Extract toast messages for consistency:
+const TOAST_MESSAGES = { + COPY_SUCCESS: "✅ Copied to clipboard", + FEEDBACK_SUCCESS: "✅ Feedback submitted", + FEEDBACK_ERROR: (message: string) => `❌ Failed to submit feedback: ${message}`, +} as const; export const AnswerCard = forwardRef<HTMLDivElement, AnswerCardProps>(({ // ... existing code ... const onCopyAnswer = useCallback(() => { const markdownText = convertLLMOutputToPortableMarkdown(answerText); navigator.clipboard.writeText(markdownText); toast({ - description: "✅ Copied to clipboard", + description: TOAST_MESSAGES.COPY_SUCCESS, }); return true; }, [answerText, toast]); const onFeedback = useCallback(async (feedbackType: 'like' | 'dislike') => { // ... existing code ... if (isServiceError(response)) { toast({ - description: `❌ Failed to submit feedback: ${response.message}`, + description: TOAST_MESSAGES.FEEDBACK_ERROR(response.message), variant: "destructive" }); } else { toast({ - description: `✅ Feedback submitted`, + description: TOAST_MESSAGES.FEEDBACK_SUCCESS, }); // ... rest of the code ... }packages/web/src/features/chat/utils.ts (1)
33-107: Use optional chaining for cleaner code.The static analysis tool correctly identifies an opportunity to use optional chaining for better readability.
Apply optional chaining:
- const last = wordNext && wordNext[direction === 'right' ? 0 : wordNext.length - 1] + const last = wordNext?.[direction === 'right' ? 0 : wordNext.length - 1]
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (13)
packages/web/src/app/[domain]/browse/layout.tsx(2 hunks)packages/web/src/app/[domain]/chat/components/chatSidePanel.tsx(1 hunks)packages/web/src/app/[domain]/chat/components/renameChatDialog.tsx(1 hunks)packages/web/src/features/chat/components/chatBox/chatBoxToolbar.tsx(1 hunks)packages/web/src/features/chat/components/chatBox/suggestionsBox.tsx(1 hunks)packages/web/src/features/chat/components/chatBox/useSuggestionModeAndQuery.ts(1 hunks)packages/web/src/features/chat/components/chatThread/answerCard.tsx(1 hunks)packages/web/src/features/chat/components/chatThread/chatThreadListItem.tsx(1 hunks)packages/web/src/features/chat/components/chatThread/codeFoldingExpandButton.tsx(1 hunks)packages/web/src/features/chat/components/chatThread/codeFoldingExtension.test.ts(1 hunks)packages/web/src/features/chat/components/chatThread/codeFoldingExtension.ts(1 hunks)packages/web/src/features/chat/components/chatThread/markdownRenderer.tsx(1 hunks)packages/web/src/features/chat/utils.ts(1 hunks)
📓 Path-based instructions (1)
**/*
📄 CodeRabbit Inference Engine (.cursor/rules/style.mdc)
Filenames should always be camelCase. Exception: if there are filenames in the same directory with a format other than camelCase, use that format to keep things consistent.
Files:
packages/web/src/features/chat/components/chatThread/markdownRenderer.tsxpackages/web/src/app/[domain]/chat/components/chatSidePanel.tsxpackages/web/src/features/chat/components/chatThread/codeFoldingExtension.tspackages/web/src/features/chat/components/chatThread/answerCard.tsxpackages/web/src/features/chat/components/chatThread/codeFoldingExtension.test.tspackages/web/src/features/chat/utils.ts
🧬 Code Graph Analysis (1)
packages/web/src/features/chat/components/chatThread/codeFoldingExtension.test.ts (2)
packages/web/src/features/chat/types.ts (1)
FileReference(34-34)packages/web/src/features/chat/components/chatThread/codeFoldingExtension.ts (8)
calculateVisibleRanges(43-86)calculateHiddenRegions(88-133)createCodeFoldingExtension(364-490)FoldingState(26-32)updateReferencesEffect(35-35)expandRegionEffect(36-40)updateReferences(230-234)expandRegion(236-240)
🪛 Biome (1.9.4)
packages/web/src/features/chat/utils.ts
[error] 68-68: Change to an optional chain.
Unsafe fix: Change to an optional chain.
(lint/complexity/useOptionalChain)
🚧 Files skipped from review as they are similar to previous changes (7)
- packages/web/src/app/[domain]/browse/layout.tsx
- packages/web/src/features/chat/components/chatBox/chatBoxToolbar.tsx
- packages/web/src/app/[domain]/chat/components/renameChatDialog.tsx
- packages/web/src/features/chat/components/chatBox/useSuggestionModeAndQuery.ts
- packages/web/src/features/chat/components/chatBox/suggestionsBox.tsx
- packages/web/src/features/chat/components/chatThread/codeFoldingExpandButton.tsx
- packages/web/src/features/chat/components/chatThread/chatThreadListItem.tsx
🧰 Additional context used
📓 Path-based instructions (1)
**/*
📄 CodeRabbit Inference Engine (.cursor/rules/style.mdc)
Filenames should always be camelCase. Exception: if there are filenames in the same directory with a format other than camelCase, use that format to keep things consistent.
Files:
packages/web/src/features/chat/components/chatThread/markdownRenderer.tsxpackages/web/src/app/[domain]/chat/components/chatSidePanel.tsxpackages/web/src/features/chat/components/chatThread/codeFoldingExtension.tspackages/web/src/features/chat/components/chatThread/answerCard.tsxpackages/web/src/features/chat/components/chatThread/codeFoldingExtension.test.tspackages/web/src/features/chat/utils.ts
🧬 Code Graph Analysis (1)
packages/web/src/features/chat/components/chatThread/codeFoldingExtension.test.ts (2)
packages/web/src/features/chat/types.ts (1)
FileReference(34-34)packages/web/src/features/chat/components/chatThread/codeFoldingExtension.ts (8)
calculateVisibleRanges(43-86)calculateHiddenRegions(88-133)createCodeFoldingExtension(364-490)FoldingState(26-32)updateReferencesEffect(35-35)expandRegionEffect(36-40)updateReferences(230-234)expandRegion(236-240)
🪛 Biome (1.9.4)
packages/web/src/features/chat/utils.ts
[error] 68-68: Change to an optional chain.
Unsafe fix: Change to an optional chain.
(lint/complexity/useOptionalChain)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: build
🔇 Additional comments (11)
packages/web/src/features/chat/components/chatThread/markdownRenderer.tsx (1)
26-41: LGTM!The plugin correctly identifies and annotates block vs inline code elements.
packages/web/src/features/chat/components/chatThread/codeFoldingExtension.ts (3)
42-86: LGTM!The visible range calculation logic is well-implemented with proper handling of padding, merging, and edge cases.
88-133: LGTM!The hidden region calculation correctly identifies gaps between visible ranges and properly sets expansion direction flags.
364-491: Well-structured CodeMirror extension implementation.The state field management, decoration handling, and gutter width updates are properly implemented. The extension correctly handles document changes and state effects.
packages/web/src/features/chat/components/chatThread/codeFoldingExtension.test.ts (1)
1-691: Excellent test coverage!The test suite thoroughly covers all aspects of the code folding extension including edge cases, state transitions, and complex scenarios. Well-structured and comprehensive.
packages/web/src/features/chat/utils.ts (6)
18-31: LGTM!Proper implementation of Slate mention insertion.
109-119: LGTM!Well-implemented type guards for Slate elements.
121-144: LGTM!Proper recursive conversion of Slate content to string format.
240-255: LGTM!Clean implementation for converting file references to markdown links.
257-284: LGTM!Robust implementation for grouping message parts into logical steps.
286-303: LGTM!Well-designed logic for extracting answer parts with appropriate fallback behavior.
packages/web/src/features/chat/components/chatThread/markdownRenderer.tsx
Show resolved
Hide resolved
packages/web/src/features/chat/components/chatThread/markdownRenderer.tsx
Show resolved
Hide resolved
packages/web/src/features/chat/components/chatThread/markdownRenderer.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Actionable comments posted: 10
♻️ Duplicate comments (4)
docs/snippets/schemas/v3/index.schema.mdx (2)
1158-1161: Replace invalid OpenAI model name with official model.The example "o3-deep-research" is not an official OpenAI model name. Replace it with "o3-pro" as verified in previous reviews.
- "o3-deep-research" + "o3-pro"
1518-1523: Replace invalid OpenAI model name with official model (duplicate occurrence).This is another occurrence of the invalid "o3-deep-research" model name that should be replaced with "o3-pro".
- "o3-deep-research" + "o3-pro"packages/schemas/src/v3/index.schema.ts (1)
1145-1866: Eliminate schema duplication by referencing definitions.The provider schemas are duplicated - they're defined both in the
definitionsobject and repeated in theoneOfarray. This creates maintenance overhead and potential for inconsistencies.Apply this pattern to reference definitions instead of duplicating:
"oneOf": [ { - "type": "object", - "properties": { - "provider": { - "const": "openai", - "description": "OpenAI Configuration" - }, - // ... rest of duplicated schema - }, - "required": [ - "provider", - "model" - ], - "additionalProperties": false + "$ref": "#/definitions/LanguageModel/definitions/OpenAILanguageModel" }, { - "type": "object", - "properties": { - "provider": { - "const": "amazon-bedrock", - // ... rest of duplicated schema - } - } + "$ref": "#/definitions/LanguageModel/definitions/AmazonBedrockLanguageModel" }, // ... similar changes for other providers ]packages/web/src/app/api/(server)/chat/route.ts (1)
144-153: Error handling for chat title update is still missing.This is the same issue identified in the past review comment. The
updateChatNamecall remains fire-and-forget without proper error handling.
🧹 Nitpick comments (1)
packages/web/src/app/api/(server)/chat/route.ts (1)
218-219: Fix trailing comma and formatting.There's an unnecessary empty line and missing semicolon that affects code readability.
writer.write({ type: 'message-metadata', messageMetadata: { totalTokens: totalUsage.totalTokens, totalInputTokens: totalUsage.inputTokens, totalOutputTokens: totalUsage.outputTokens, totalResponseTimeMs: new Date().getTime() - startTime.getTime(), modelName: languageModelConfig.displayName ?? languageModelConfig.model, } - }) - - + });
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (11)
docs/snippets/schemas/v3/index.schema.mdx(1 hunks)docs/snippets/schemas/v3/languageModel.schema.mdx(1 hunks)packages/schemas/src/v3/index.schema.ts(1 hunks)packages/schemas/src/v3/index.type.ts(3 hunks)packages/schemas/src/v3/languageModel.schema.ts(1 hunks)packages/schemas/src/v3/languageModel.type.ts(1 hunks)packages/web/package.json(6 hunks)packages/web/src/app/api/(server)/chat/route.ts(1 hunks)packages/web/src/env.mjs(1 hunks)packages/web/src/features/chat/components/chatBox/modelProviderLogo.tsx(1 hunks)schemas/v3/languageModel.json(1 hunks)
📓 Path-based instructions (1)
**/*
📄 CodeRabbit Inference Engine (.cursor/rules/style.mdc)
Filenames should always be camelCase. Exception: if there are filenames in the same directory with a format other than camelCase, use that format to keep things consistent.
Files:
packages/web/src/app/api/(server)/chat/route.tspackages/schemas/src/v3/languageModel.type.tsdocs/snippets/schemas/v3/index.schema.mdxpackages/schemas/src/v3/index.schema.ts
✅ Files skipped from review due to trivial changes (2)
- schemas/v3/languageModel.json
- docs/snippets/schemas/v3/languageModel.schema.mdx
🚧 Files skipped from review as they are similar to previous changes (5)
- packages/web/src/features/chat/components/chatBox/modelProviderLogo.tsx
- packages/schemas/src/v3/languageModel.schema.ts
- packages/web/package.json
- packages/web/src/env.mjs
- packages/schemas/src/v3/index.type.ts
🧰 Additional context used
📓 Path-based instructions (1)
**/*
📄 CodeRabbit Inference Engine (.cursor/rules/style.mdc)
Filenames should always be camelCase. Exception: if there are filenames in the same directory with a format other than camelCase, use that format to keep things consistent.
Files:
packages/web/src/app/api/(server)/chat/route.tspackages/schemas/src/v3/languageModel.type.tsdocs/snippets/schemas/v3/index.schema.mdxpackages/schemas/src/v3/index.schema.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: build
🔇 Additional comments (3)
packages/schemas/src/v3/languageModel.type.ts (1)
1-208: Well-structured type definitions for multi-provider AI model support.The TypeScript type definitions comprehensively cover all major AI providers with appropriate authentication mechanisms and provider-specific configurations. The union type approach ensures type safety while maintaining flexibility.
docs/snippets/schemas/v3/index.schema.mdx (1)
1140-1869: Comprehensive language model schema with proper validation.The new
modelsarray property provides excellent support for multi-provider AI model configurations. TheoneOfconstraint ensures strict validation while maintaining flexibility for provider-specific requirements.packages/schemas/src/v3/index.schema.ts (1)
1139-1142: LGTM! Well-structured models property declaration.The new models array property is properly defined with clear description and appropriate item schema structure.
There was a problem hiding this comment.
Actionable comments posted: 0
♻️ Duplicate comments (2)
packages/web/src/app/[domain]/chat/[id]/components/chatThreadPanel.tsx (1)
41-48: The error handling issue from previous review still exists.The catch block only logs to console without providing user feedback, as identified in the previous review.
Apply the suggested fix from the previous review:
try { const { inputMessage, selectedRepos } = JSON.parse(setChatState) as SetChatStatePayload; setInputMessage(inputMessage); setSelectedRepos(selectedRepos); - } catch { - console.error('Invalid message in URL'); + } catch (error) { + console.error('Failed to parse chat state from URL:', error); + // Consider showing a user-friendly error notification }packages/web/src/features/chat/components/chatThread/chatThread.tsx (1)
269-284: The React Fragment key issue from previous review still exists.The Fragment wrapping
ChatThreadListItemandSeparatorcomponents is missing a key prop, which is required when rendering Fragments in an array.Apply the suggested fix:
return ( - <> + <React.Fragment key={`message-pair-${index}`}> <ChatThreadListItem key={index} chatId={chatId} userMessage={userMessage} assistantMessage={assistantMessage} isStreaming={isStreaming} sources={sources} ref={isLastPair ? latestMessagePairRef : undefined} /> {index !== messagePairs.length - 1 && ( <Separator className="my-12" /> )} - </> + </React.Fragment> );You'll also need to import React at the top of the file:
+'use client'; + +import React from 'react';
🧹 Nitpick comments (1)
packages/web/src/app/[domain]/chat/[id]/components/chatThreadPanel.tsx (1)
27-29: Consider defensive programming for the non-null assertion.While the comment explains that
chatIdis guaranteed to exist, using a non-null assertion operator can be risky if the assumption is ever violated.Consider adding a runtime check:
- // @note: we are guaranteed to have a chatId because this component will only be - // mounted when on a /chat/[id] route. - const chatId = useChatId()!; + const chatId = useChatId(); + + if (!chatId) { + throw new Error('ChatThreadPanel must be used within a chat route with an ID'); + }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (11)
packages/web/src/app/[domain]/chat/[id]/components/chatThreadPanel.tsx(1 hunks)packages/web/src/app/[domain]/chat/[id]/page.tsx(1 hunks)packages/web/src/app/[domain]/chat/components/newChatPanel.tsx(1 hunks)packages/web/src/app/[domain]/chat/page.tsx(1 hunks)packages/web/src/app/[domain]/components/homepage/agenticSearch.tsx(1 hunks)packages/web/src/app/[domain]/components/homepage/index.tsx(1 hunks)packages/web/src/env.mjs(1 hunks)packages/web/src/features/chat/components/chatBox/chatBoxToolbar.tsx(1 hunks)packages/web/src/features/chat/components/chatBox/repoSelector.tsx(1 hunks)packages/web/src/features/chat/components/chatThread/chatThread.tsx(1 hunks)packages/web/src/features/chat/components/chatThread/chatThreadListItem.tsx(1 hunks)
📓 Path-based instructions (1)
**/*
📄 CodeRabbit Inference Engine (.cursor/rules/style.mdc)
Filenames should always be camelCase. Exception: if there are filenames in the same directory with a format other than camelCase, use that format to keep things consistent.
Files:
packages/web/src/app/[domain]/chat/[id]/components/chatThreadPanel.tsxpackages/web/src/features/chat/components/chatThread/chatThread.tsx
🧠 Learnings (1)
packages/web/src/app/[domain]/chat/[id]/components/chatThreadPanel.tsx (2)
Learnt from: brendan-kellam
PR: #307
File: packages/backend/src/repoCompileUtils.ts:491-503
Timestamp: 2025-05-14T19:20:48.667Z
Learning: SSH/SCP-style Git URLs (like [email protected]:org/repo.git) throw errors when passed directly to JavaScript's new URL() constructor. A fix is to convert them using: new URL(ssh://${url.replace(':', '/')}) for non-HTTP URLs.
Learnt from: brendan-kellam
PR: #307
File: packages/backend/src/repoCompileUtils.ts:491-503
Timestamp: 2025-05-14T19:20:48.667Z
Learning: SSH/SCP-style Git URLs (like [email protected]:org/repo.git) throw errors when passed directly to JavaScript's new URL() constructor. A fix is to convert them using: new URL(ssh://${url.replace(':', '/')}) for non-HTTP URLs.
🧬 Code Graph Analysis (1)
packages/web/src/app/[domain]/chat/[id]/components/chatThreadPanel.tsx (5)
packages/web/src/features/chat/types.ts (4)
LanguageModelInfo(146-150)SBChatMessage(69-73)SET_CHAT_STATE_QUERY_PARAM(134-134)SetChatStatePayload(136-139)packages/web/src/lib/types.ts (1)
RepositoryQuery(28-28)packages/web/src/app/[domain]/chat/useChatId.ts (1)
useChatId(5-8)packages/web/src/components/ui/resizable.tsx (1)
ResizablePanel(48-48)packages/web/src/features/chat/components/chatThread/chatThread.tsx (1)
ChatThread(42-336)
🚧 Files skipped from review as they are similar to previous changes (9)
- packages/web/src/app/[domain]/chat/page.tsx
- packages/web/src/app/[domain]/chat/components/newChatPanel.tsx
- packages/web/src/features/chat/components/chatBox/chatBoxToolbar.tsx
- packages/web/src/features/chat/components/chatBox/repoSelector.tsx
- packages/web/src/app/[domain]/components/homepage/agenticSearch.tsx
- packages/web/src/app/[domain]/components/homepage/index.tsx
- packages/web/src/app/[domain]/chat/[id]/page.tsx
- packages/web/src/env.mjs
- packages/web/src/features/chat/components/chatThread/chatThreadListItem.tsx
🧰 Additional context used
📓 Path-based instructions (1)
**/*
📄 CodeRabbit Inference Engine (.cursor/rules/style.mdc)
Filenames should always be camelCase. Exception: if there are filenames in the same directory with a format other than camelCase, use that format to keep things consistent.
Files:
packages/web/src/app/[domain]/chat/[id]/components/chatThreadPanel.tsxpackages/web/src/features/chat/components/chatThread/chatThread.tsx
🧠 Learnings (1)
packages/web/src/app/[domain]/chat/[id]/components/chatThreadPanel.tsx (2)
Learnt from: brendan-kellam
PR: #307
File: packages/backend/src/repoCompileUtils.ts:491-503
Timestamp: 2025-05-14T19:20:48.667Z
Learning: SSH/SCP-style Git URLs (like [email protected]:org/repo.git) throw errors when passed directly to JavaScript's new URL() constructor. A fix is to convert them using: new URL(ssh://${url.replace(':', '/')}) for non-HTTP URLs.
Learnt from: brendan-kellam
PR: #307
File: packages/backend/src/repoCompileUtils.ts:491-503
Timestamp: 2025-05-14T19:20:48.667Z
Learning: SSH/SCP-style Git URLs (like [email protected]:org/repo.git) throw errors when passed directly to JavaScript's new URL() constructor. A fix is to convert them using: new URL(ssh://${url.replace(':', '/')}) for non-HTTP URLs.
🧬 Code Graph Analysis (1)
packages/web/src/app/[domain]/chat/[id]/components/chatThreadPanel.tsx (5)
packages/web/src/features/chat/types.ts (4)
LanguageModelInfo(146-150)SBChatMessage(69-73)SET_CHAT_STATE_QUERY_PARAM(134-134)SetChatStatePayload(136-139)packages/web/src/lib/types.ts (1)
RepositoryQuery(28-28)packages/web/src/app/[domain]/chat/useChatId.ts (1)
useChatId(5-8)packages/web/src/components/ui/resizable.tsx (1)
ResizablePanel(48-48)packages/web/src/features/chat/components/chatThread/chatThread.tsx (1)
ChatThread(42-336)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: build
🔇 Additional comments (7)
packages/web/src/app/[domain]/chat/[id]/components/chatThreadPanel.tsx (1)
1-75: Component implementation looks solid overall.The component properly handles URL state initialization, manages local state for input messages and selected repositories, and integrates well with the chat system architecture.
packages/web/src/features/chat/components/chatThread/chatThread.tsx (6)
152-190: Excellent scroll position management implementation.The scroll tracking logic with debouncing and history state management is well-implemented. The auto-scroll detection using a threshold and proper cleanup of event listeners shows good attention to detail.
125-128: Navigation guard implementation looks good.Properly prevents navigation during message submission or streaming with a user-friendly confirmation dialog.
99-120: Robust message sending implementation.The callback properly validates the selected language model, provides user feedback via toast, and manages source synchronization. The error handling and parameter passing are well-structured.
290-308: Smart auto-scroll behavior with good UX.The conditional rendering of the scroll-to-bottom button during streaming when auto-scroll is disabled provides excellent user experience. The bounce animation adds a nice touch.
271-279: Potential performance issue with duplicate key prop.The
ChatThreadListItemcomponent has both akey={index}prop and is wrapped in a Fragment that should also have a key. This creates duplicate keys in the same scope.When adding the Fragment key, remove the duplicate key from the inner component:
<React.Fragment key={`message-pair-${index}`}> <ChatThreadListItem - key={index} chatId={chatId} userMessage={userMessage} assistantMessage={assistantMessage} isStreaming={isStreaming} sources={sources} ref={isLastPair ? latestMessagePairRef : undefined} />Likely an incorrect or invalid review comment.
63-69: Initial data-source filtering is correct.The
.filter((part) => part.type === 'data-source')check inchatThread.tsxaligns with how parts are created elsewhere:
- In
packages/web/src/features/chat/utils.ts(around line 203), messages are built with
{ type: 'data-source', data }.- In
chatThread.tsx, both the initial state and theonDatacallback use the same literal.No changes needed.
There was a problem hiding this comment.
Actionable comments posted: 2
♻️ Duplicate comments (14)
packages/web/src/app/api/(server)/chat/route.ts (9)
1-32: Imports look comprehensive but verify AI SDK dependencies.The extensive AI SDK imports are well-organized for supporting multiple language model providers.
37-42: Fix schema validation issues.The schema definition has the same issues previously identified: typo in comment and unsafe
z.any()usage for messages array.
75-83: Add proper error handling to stream merging.The function still lacks error handling in the Promise constructor, which could cause unhandled promise rejections if the stream fails.
114-117: Add validation for message structure before accessing parts.The code still assumes
latestMessage.partsexists without validation, which could cause runtime errors if the message structure is malformed.
145-154: Add error handling for chat title update.The
updateChatNamecall is still fire-and-forget without proper error handling, which could result in silent failures.
159-176: Handle edge cases in message history extraction.The message filtering logic still has the same edge cases identified previously: unsafe array access and missing validation for message parts.
228-233: Add error handling for message persistence.The
updateChatMessagescall in theonFinishcallback still lacks error handling, risking silent failures when saving chat state.
254-268: Security concern: Potential prompt injection in chat title generation.The user message is still directly interpolated into the prompt without sanitization, creating the same prompt injection vulnerability identified previously.
402-403: Add exhaustive case handling for provider switch.The switch statement still lacks a default case, which could cause silent failures if new providers are added.
docs/snippets/schemas/v3/index.schema.mdx (1)
1158-1161: Update OpenAI model examples to use official model names.The examples still include "o3-deep-research" which is not an official OpenAI model name. This should be updated to "o3-pro" as suggested in the previous review.
Also applies to: 1594-1597
packages/schemas/src/v3/index.schema.ts (2)
1145-2016: Eliminate schema duplication by referencing definitions.The provider schemas are duplicated - they're defined both in the
definitionsobject and repeated in theoneOfarray. This creates maintenance overhead and potential for inconsistencies.Apply this pattern to reference definitions instead of duplicating:
"oneOf": [ { - "type": "object", - "properties": { - "provider": { - "const": "openai", - "description": "OpenAI Configuration" - }, - // ... rest of duplicated schema - }, - "required": [ - "provider", - "model" - ], - "additionalProperties": false + "$ref": "#/definitions/LanguageModel/definitions/OpenAILanguageModel" }, { - "type": "object", - "properties": { - "provider": { - "const": "amazon-bedrock", - // ... rest of duplicated schema - } - } + "$ref": "#/definitions/LanguageModel/definitions/AmazonBedrockLanguageModel" }, // ... similar changes for other providers ]
1157-1161: Update OpenAI model examples to match current offerings.Based on the latest (July 2025) model lineup, the GPT-4 and o-series names should be updated to reflect actual available models.
Please update the enum to:
- "examples": [ - "gpt-4.1", - "o4-mini", - "o3", - "o3-deep-research" - ] + "examples": [ + "gpt-4o", + "gpt-4.1", + "gpt-4.5", + "gpt-4o-mini", + "o1", + "o3", + "o3-pro", + "o4-mini" + ]Also applies to lines 1593-1597 in the duplicated oneOf section.
packages/schemas/src/v3/index.type.ts (2)
14-20: Avoid duplicate type definitions - these types already exist inlanguageModel.type.tsThe
LanguageModelunion type is already defined inpackages/schemas/src/v3/languageModel.type.ts. This duplication will lead to maintenance issues and potential type conflicts.Consider importing the type from
languageModel.type.tsinstead:export { LanguageModel } from './languageModel.type';
431-670: Avoid duplicate type definitions and fix misleading comments.Two issues identified that were flagged in past reviews:
- Type Duplication: All these language model interfaces are already defined in
packages/schemas/src/v3/languageModel.type.ts.- Misleading Comments: References to "declarative connection configs" at lines 456, 489, 505, 544, 578, 620, 662 are inappropriate in language model contexts.
Consider importing these types from
languageModel.type.tsinstead:export { OpenAILanguageModel, AmazonBedrockLanguageModel, AnthropicLanguageModel, GoogleGenerativeAILanguageModel, GoogleVertexLanguageModel, GoogleVertexAnthropicLanguageModel } from './languageModel.type';
🧹 Nitpick comments (1)
packages/web/src/app/api/(server)/chat/route.ts (1)
397-397: Remove debugging console.log statement.The console.log statement appears to be leftover debugging code and should be removed from production code.
- console.log(modelId);
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (10)
docs/snippets/schemas/v3/index.schema.mdx(1 hunks)docs/snippets/schemas/v3/languageModel.schema.mdx(1 hunks)packages/schemas/src/v3/index.schema.ts(1 hunks)packages/schemas/src/v3/index.type.ts(3 hunks)packages/schemas/src/v3/languageModel.schema.ts(1 hunks)packages/schemas/src/v3/languageModel.type.ts(1 hunks)packages/web/package.json(6 hunks)packages/web/src/app/api/(server)/chat/route.ts(1 hunks)packages/web/src/features/chat/components/chatBox/modelProviderLogo.tsx(1 hunks)schemas/v3/languageModel.json(1 hunks)
📓 Path-based instructions (1)
**/*
📄 CodeRabbit Inference Engine (.cursor/rules/style.mdc)
Filenames should always be camelCase. Exception: if there are filenames in the same directory with a format other than camelCase, use that format to keep things consistent.
Files:
packages/web/src/app/api/(server)/chat/route.tsdocs/snippets/schemas/v3/index.schema.mdxpackages/schemas/src/v3/languageModel.type.tspackages/schemas/src/v3/index.schema.tsschemas/v3/languageModel.jsonpackages/schemas/src/v3/index.type.ts
🧬 Code Graph Analysis (2)
packages/schemas/src/v3/languageModel.type.ts (1)
packages/schemas/src/v3/index.type.ts (7)
LanguageModel(14-20)OpenAILanguageModel(431-464)AmazonBedrockLanguageModel(465-518)AnthropicLanguageModel(519-552)GoogleGenerativeAILanguageModel(553-586)GoogleVertexLanguageModel(587-628)GoogleVertexAnthropicLanguageModel(629-670)
packages/schemas/src/v3/index.type.ts (1)
packages/schemas/src/v3/languageModel.type.ts (7)
LanguageModel(3-9)OpenAILanguageModel(11-44)AmazonBedrockLanguageModel(45-98)AnthropicLanguageModel(99-132)GoogleGenerativeAILanguageModel(133-166)GoogleVertexLanguageModel(167-208)GoogleVertexAnthropicLanguageModel(209-250)
🚧 Files skipped from review as they are similar to previous changes (4)
- packages/web/src/features/chat/components/chatBox/modelProviderLogo.tsx
- packages/schemas/src/v3/languageModel.schema.ts
- packages/web/package.json
- docs/snippets/schemas/v3/languageModel.schema.mdx
🧰 Additional context used
📓 Path-based instructions (1)
**/*
📄 CodeRabbit Inference Engine (.cursor/rules/style.mdc)
Filenames should always be camelCase. Exception: if there are filenames in the same directory with a format other than camelCase, use that format to keep things consistent.
Files:
packages/web/src/app/api/(server)/chat/route.tsdocs/snippets/schemas/v3/index.schema.mdxpackages/schemas/src/v3/languageModel.type.tspackages/schemas/src/v3/index.schema.tsschemas/v3/languageModel.jsonpackages/schemas/src/v3/index.type.ts
🧬 Code Graph Analysis (2)
packages/schemas/src/v3/languageModel.type.ts (1)
packages/schemas/src/v3/index.type.ts (7)
LanguageModel(14-20)OpenAILanguageModel(431-464)AmazonBedrockLanguageModel(465-518)AnthropicLanguageModel(519-552)GoogleGenerativeAILanguageModel(553-586)GoogleVertexLanguageModel(587-628)GoogleVertexAnthropicLanguageModel(629-670)
packages/schemas/src/v3/index.type.ts (1)
packages/schemas/src/v3/languageModel.type.ts (7)
LanguageModel(3-9)OpenAILanguageModel(11-44)AmazonBedrockLanguageModel(45-98)AnthropicLanguageModel(99-132)GoogleGenerativeAILanguageModel(133-166)GoogleVertexLanguageModel(167-208)GoogleVertexAnthropicLanguageModel(209-250)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: build
🔇 Additional comments (10)
packages/web/src/app/api/(server)/chat/route.ts (2)
44-73: Clean request handling with proper validation.The POST handler correctly validates the required domain header, safely parses the request schema, and properly handles both success and error cases with appropriate HTTP responses.
405-419: Well-implemented error handling utility.The error handler comprehensively handles different error types (null, string, Error instances) with appropriate fallbacks, providing robust error message conversion.
schemas/v3/languageModel.json (4)
1-271: Well-structured JSON schema for multi-provider language models.The schema correctly uses the
oneOfconstruct to enforce exactly one provider selection and properly defines all provider-specific schemas in thedefinitionssection before referencing them.
33-33: Consistent URL validation across all providers.The
baseUrlpattern^https?:\\/\\/[^\\s/$.?#].[^\\s]*$is correctly applied consistently across all provider schemas and provides appropriate HTTP/HTTPS URL validation.Also applies to: 78-78, 110-110, 142-142, 192-192, 240-240
27-27: Consistent use of shared Token definition for credential fields.All authentication fields properly reference
./shared.json#/definitions/Token, promoting consistency and reuse across provider configurations.Also applies to: 59-59, 63-63, 104-104, 136-136, 186-186, 234-234
37-40: Consistent required field definitions across all providers.All provider schemas correctly require only
providerandmodelfields, maintaining consistency while allowing flexible optional authentication configuration.Also applies to: 82-85, 114-117, 146-149, 196-199, 244-247
docs/snippets/schemas/v3/index.schema.mdx (1)
1140-2018: Well-structured models array property for language model configurations.The new
modelsproperty correctly defines an array of language model configurations with properoneOfvalidation ensuring each item matches exactly one provider schema.packages/schemas/src/v3/languageModel.type.ts (1)
1-1: Auto-generated file comment appropriately warns against manual modification.The comment correctly indicates this is auto-generated, which explains the type duplication with
index.type.ts. However, ensure the generation process is maintaining consistency between both locations.packages/schemas/src/v3/index.schema.ts (1)
1139-1142: LGTM! Clean addition of the models property.The new
modelsproperty is well-structured with appropriate description and array typing for language model configurations.packages/schemas/src/v3/index.type.ts (1)
37-40: LGTM! Clean addition of models property to SourcebotConfig.The new
modelsproperty is properly typed and documented, providing the TypeScript interface for language model configurations.
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (1)
packages/web/src/app/globals.css (1)
5-6: Fix @import rule positioning.The
@importrule must be positioned before other CSS rules. This issue was already identified in a previous review.
🧹 Nitpick comments (2)
docs/docs/features/ask.mdx (1)
45-46: Consider using a more distinctive phrase for better writing style.The phrase "Feel free to join the discussion" could be replaced with a more unique alternative to enhance the professional tone.
-We believe this experience of understanding your codebase is superior, and we hope you find it useful. We'd love to know what you think! Feel free to join the discussion on our +We believe this experience of understanding your codebase is superior, and we hope you find it useful. We'd love to know what you think! Join the discussion on ourpackages/web/src/features/chat/components/chatBox/chatBox.tsx (1)
382-396: Consider refactoring platform-specific rendering logic.The Mac vs non-Mac conditional rendering in the
MentionComponentseems to address a Slate.js issue but creates complexity. Consider extracting this logic into a helper function or component for better readability.+const renderMentionContent = (data: any, children: React.ReactNode) => { + const icon = <VscodeFileIcon fileName={data.name} className="w-3 h-3 mr-1" />; + + return IS_MAC ? ( + <> + {children} + {icon} + {data.name} + </> + ) : ( + <> + {icon} + {data.name} + {children} + </> + ); +}; const MentionComponent = ({ attributes, children, element: { data }, }: RenderElementPropsFor<MentionElement>) => { const selected = useSelected(); const focused = useFocused(); if (data.type === 'file') { return ( <Tooltip> <TooltipTrigger asChild> <span {...attributes} contentEditable={false} className={cn( "px-1.5 py-0.5 mr-1.5 mb-1 align-baseline inline-block rounded bg-muted text-xs font-mono", { "ring-2 ring-blue-300": selected && focused } )} > <span contentEditable={false} className="flex flex-row items-center select-none"> - {/* @see: https://github.com/ianstormtaylor/slate/issues/3490 */} - {IS_MAC ? ( - <Fragment> - {children} - <VscodeFileIcon fileName={data.name} className="w-3 h-3 mr-1" /> - {data.name} - </Fragment> - ) : ( - <Fragment> - <VscodeFileIcon fileName={data.name} className="w-3 h-3 mr-1" /> - {data.name} - {children} - </Fragment> - )} + {renderMentionContent(data, children)} </span> </span> </TooltipTrigger>
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
docs/images/ask_sourcebot_low_res.mp4is excluded by!**/*.mp4
📒 Files selected for processing (18)
docs/docs.json(2 hunks)docs/docs/configuration/language-model-providers.mdx(1 hunks)docs/docs/features/ask.mdx(1 hunks)docs/docs/features/search/overview.mdx(1 hunks)docs/docs/overview.mdx(2 hunks)packages/web/src/app/[domain]/chat/[id]/components/chatThreadPanel.tsx(1 hunks)packages/web/src/app/[domain]/chat/components/newChatPanel.tsx(1 hunks)packages/web/src/app/[domain]/components/homepage/agenticSearch.tsx(1 hunks)packages/web/src/app/[domain]/components/homepage/toolbar.tsx(1 hunks)packages/web/src/app/globals.css(9 hunks)packages/web/src/features/chat/components/chatBox/chatBox.tsx(1 hunks)packages/web/src/features/chat/components/chatBox/chatBoxToolbar.tsx(1 hunks)packages/web/src/features/chat/components/chatBox/repoSelector.tsx(1 hunks)packages/web/src/features/chat/components/chatThread/chatThread.tsx(1 hunks)packages/web/src/features/chat/types.ts(1 hunks)packages/web/src/features/chat/useCreateNewChatThread.ts(1 hunks)packages/web/src/features/chat/utils.ts(1 hunks)packages/web/tailwind.config.ts(1 hunks)
📓 Path-based instructions (1)
**/*
📄 CodeRabbit Inference Engine (.cursor/rules/style.mdc)
Filenames should always be camelCase. Exception: if there are filenames in the same directory with a format other than camelCase, use that format to keep things consistent.
Files:
docs/docs/overview.mdxpackages/web/tailwind.config.tspackages/web/src/features/chat/components/chatBox/chatBox.tsxdocs/docs/features/ask.mdxpackages/web/src/app/globals.csspackages/web/src/features/chat/utils.ts
🧬 Code Graph Analysis (1)
packages/web/src/features/chat/utils.ts (2)
packages/web/src/features/chat/types.ts (11)
CustomEditor(114-118)MentionData(100-100)MentionElement(102-106)CustomText(83-83)ParagraphElement(85-89)SBChatMessage(70-74)Source(23-23)FileSource(18-18)SBChatMessageToolTypes(57-62)FileReference(34-34)SBChatMessagePart(76-79)packages/web/src/features/chat/constants.ts (3)
FILE_REFERENCE_PREFIX(2-2)FILE_REFERENCE_REGEX(3-3)ANSWER_TAG(5-5)
🪛 LanguageTool
docs/docs/features/ask.mdx
[style] ~45-~45: Consider using a less common alternative to make your writing sound more unique and professional.
Context: ...eful. We'd love to know what you think! Feel free to join the discussion on our [GitHub](htt...
(FEEL_FREE_TO_STYLE_ME)
🪛 Biome (1.9.4)
packages/web/src/app/globals.css
[error] 5-5: This @import is in the wrong position.
Any @import rules must precede all other valid at-rules and style rules in a stylesheet (ignoring @charset and @layer), or else the @import rule is invalid.
Consider moving import position.
(lint/correctness/noInvalidPositionAtImportRule)
packages/web/src/features/chat/utils.ts
[error] 68-68: Change to an optional chain.
Unsafe fix: Change to an optional chain.
(lint/complexity/useOptionalChain)
✅ Files skipped from review due to trivial changes (3)
- docs/docs/configuration/language-model-providers.mdx
- docs/docs/features/search/overview.mdx
- docs/docs.json
🚧 Files skipped from review as they are similar to previous changes (9)
- packages/web/src/features/chat/useCreateNewChatThread.ts
- packages/web/src/features/chat/components/chatBox/repoSelector.tsx
- packages/web/src/app/[domain]/chat/components/newChatPanel.tsx
- packages/web/src/features/chat/components/chatBox/chatBoxToolbar.tsx
- packages/web/src/app/[domain]/components/homepage/agenticSearch.tsx
- packages/web/src/app/[domain]/components/homepage/toolbar.tsx
- packages/web/src/app/[domain]/chat/[id]/components/chatThreadPanel.tsx
- packages/web/src/features/chat/components/chatThread/chatThread.tsx
- packages/web/src/features/chat/types.ts
🧰 Additional context used
📓 Path-based instructions (1)
**/*
📄 CodeRabbit Inference Engine (.cursor/rules/style.mdc)
Filenames should always be camelCase. Exception: if there are filenames in the same directory with a format other than camelCase, use that format to keep things consistent.
Files:
docs/docs/overview.mdxpackages/web/tailwind.config.tspackages/web/src/features/chat/components/chatBox/chatBox.tsxdocs/docs/features/ask.mdxpackages/web/src/app/globals.csspackages/web/src/features/chat/utils.ts
🧬 Code Graph Analysis (1)
packages/web/src/features/chat/utils.ts (2)
packages/web/src/features/chat/types.ts (11)
CustomEditor(114-118)MentionData(100-100)MentionElement(102-106)CustomText(83-83)ParagraphElement(85-89)SBChatMessage(70-74)Source(23-23)FileSource(18-18)SBChatMessageToolTypes(57-62)FileReference(34-34)SBChatMessagePart(76-79)packages/web/src/features/chat/constants.ts (3)
FILE_REFERENCE_PREFIX(2-2)FILE_REFERENCE_REGEX(3-3)ANSWER_TAG(5-5)
🪛 LanguageTool
docs/docs/features/ask.mdx
[style] ~45-~45: Consider using a less common alternative to make your writing sound more unique and professional.
Context: ...eful. We'd love to know what you think! Feel free to join the discussion on our [GitHub](htt...
(FEEL_FREE_TO_STYLE_ME)
🪛 Biome (1.9.4)
packages/web/src/app/globals.css
[error] 5-5: This @import is in the wrong position.
Any @import rules must precede all other valid at-rules and style rules in a stylesheet (ignoring @charset and @layer), or else the @import rule is invalid.
Consider moving import position.
(lint/correctness/noInvalidPositionAtImportRule)
packages/web/src/features/chat/utils.ts
[error] 68-68: Change to an optional chain.
Unsafe fix: Change to an optional chain.
(lint/complexity/useOptionalChain)
🔇 Additional comments (20)
packages/web/src/app/globals.css (3)
22-22: Well-structured CSS custom properties for chat feature.The new CSS custom properties are well-organized with consistent naming conventions and proper light/dark theme coverage. The chat reference properties provide a complete interaction state system.
Also applies to: 45-45, 91-96, 113-113, 116-116, 135-135, 178-183
226-253: Comprehensive chat styling classes with proper interaction states.The new chat-specific CSS classes provide a complete interaction model with proper visual feedback. The use of CSS custom properties ensures consistent theming across light and dark modes.
306-316: Improved selection highlighting with theme-aware custom properties.The selection highlighting styles now use CSS custom properties with appropriate fallback colors for both light and dark themes, providing better visual consistency.
packages/web/tailwind.config.ts (6)
13-19: Standard container configuration looks good.The container configuration follows Tailwind best practices with appropriate centering, padding, and responsive breakpoints.
21-118: Comprehensive and well-structured color palette.The extended color configuration provides excellent theme consistency using CSS custom properties. The semantic naming, comprehensive editor syntax highlighting, and new chat reference colors create a cohesive design system.
119-124: Clean typography configuration for editor customization.The fontSize and fontFamily configurations properly use CSS custom properties, allowing for consistent editor styling that's separate from the main design system.
125-129: Consistent border radius scale using CSS custom properties.The border radius configuration creates a logical sizing hierarchy using a base CSS custom property, ensuring consistent relative sizing across the application.
130-153: Well-designed animation configuration with smooth transitions.The keyframes and animations provide smooth accordion transitions using Radix UI properties and useful slow variants for loading states. The timing and easing choices enhance user experience.
156-161: Essential plugins for animations and typography.The plugin configuration appropriately includes tailwindcss-animate for the defined animations and @tailwindcss/typography for markdown rendering in the chat feature. ESLint overrides are properly applied.
docs/docs/features/ask.mdx (1)
1-46: Well-structured documentation introducing the Ask Sourcebot feature.The documentation effectively explains the new feature, its benefits, and provides helpful navigation links. The content is clear and well-organized with appropriate use of cards, video demonstration, and contextual links.
docs/docs/overview.mdx (2)
5-8: Excellent repositioning of Sourcebot's capabilities.The updated introduction effectively broadens Sourcebot's positioning from just a "code search tool" to a comprehensive "codebase understanding" platform. The clear feature breakdown with links to detailed documentation enhances navigation.
36-54: Well-integrated Ask Sourcebot section with compelling benefits.The new section effectively introduces the AI-powered feature with clear benefits and visual demonstration. The accordion format for key benefits makes the information digestible and the video provides immediate visual context.
packages/web/src/features/chat/components/chatBox/chatBox.tsx (3)
22-32: Well-defined interface with comprehensive props.The
ChatBoxPropsinterface clearly defines all necessary properties with appropriate optional markers. The prop types are specific and provide good type safety.
88-142: Comprehensive submit validation logic with clear state management.The
useMemoimplementation for submit disabled states is well-structured, covering all necessary validation scenarios with clear reason codes. The dependency array is complete and appropriate.
184-225: Robust keyboard event handling with proper navigation.The keyboard event handling correctly manages different modes (suggestion vs normal) and implements proper arrow key navigation, Enter/Tab selection, and Escape handling. The logic properly prevents default behaviors when needed.
packages/web/src/features/chat/utils.ts (5)
1-31: Well-implemented mention insertion function.The
insertMentionfunction correctly handles Slate editor operations with proper node insertion and cursor movement. The optional target range parameter provides flexibility.
109-119: Excellent type guard implementations.The type guard functions (
isMentionElement,isCustomTextElement,isParagraphElement) are well-implemented with proper type narrowing and runtime checks.
121-144: Robust content-to-string conversion with recursive handling.The
slateContentToStringfunction properly handles different node types recursively, correctly converting mentions to their string representations and maintaining text structure.
213-236: Well-designed file reference utility functions.The functions for handling file references (
getFileReferenceId,fileReferenceToString,createFileReference) are well-structured with proper handling of optional line ranges and consistent formatting.
261-287: Efficient message grouping algorithm.The
groupMessageIntoStepsfunction implements a clean algorithm for grouping message parts by step delimiters with proper array handling and step boundary detection.
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (8)
packages/web/src/app/api/(server)/chat/route.ts (8)
38-43: Fix the typo and improve schema validation.The comment has a typo and
z.any()bypasses type safety for messages validation.
76-84: Add error handling to stream merging.The Promise lacks error handling which could cause unhandled rejections if the stream fails.
115-118: Add validation for message structure.Code assumes
latestMessage.partsexists without validation, risking runtime errors.
146-154: Add error handling for chat title update.The
updateChatNamecall lacks error handling and could fail silently.
161-179: Handle edge cases in message history extraction.The message filtering logic has unsafe array access and doesn't handle edge cases properly.
233-238: Add error handling for message persistence.The
updateChatMessagescall lacks error handling and could fail silently.
257-285: Security concern: Potential prompt injection vulnerability.User message is directly interpolated into the prompt without sanitization, creating a potential injection vulnerability.
406-407: Add exhaustive case handling for provider switch.The switch statement lacks a default case, which could cause silent failures for unhandled providers.
🧹 Nitpick comments (1)
packages/web/src/features/chat/components/chatThread/answerCard.tsx (1)
30-33: Consider conditional or lazy initialization of LangfuseWeb.The LangfuseWeb instance is created at module level, which could cause issues if environment variables aren't available and makes testing more difficult.
Consider lazy initialization:
-const langfuseWeb = new LangfuseWeb({ - publicKey: env.NEXT_PUBLIC_LANGFUSE_PUBLIC_KEY, - baseUrl: env.NEXT_PUBLIC_LANGFUSE_BASE_URL, -}); +const getLangfuseWeb = () => { + if (!env.NEXT_PUBLIC_LANGFUSE_PUBLIC_KEY || !env.NEXT_PUBLIC_LANGFUSE_BASE_URL) { + return null; + } + return new LangfuseWeb({ + publicKey: env.NEXT_PUBLIC_LANGFUSE_PUBLIC_KEY, + baseUrl: env.NEXT_PUBLIC_LANGFUSE_BASE_URL, + }); +};
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (9)
.github/workflows/_gcp-deploy.yml(1 hunks)packages/web/package.json(5 hunks)packages/web/src/app/api/(server)/chat/route.ts(1 hunks)packages/web/src/env.mjs(2 hunks)packages/web/src/features/chat/agent.ts(1 hunks)packages/web/src/features/chat/components/chatThread/answerCard.tsx(1 hunks)packages/web/src/features/chat/components/chatThread/chatThreadListItem.tsx(1 hunks)packages/web/src/features/chat/types.ts(1 hunks)packages/web/src/instrumentation.ts(1 hunks)
📓 Path-based instructions (1)
**/*
📄 CodeRabbit Inference Engine (.cursor/rules/style.mdc)
Filenames should always be camelCase. Exception: if there are filenames in the same directory with a format other than camelCase, use that format to keep things consistent.
Files:
packages/web/src/instrumentation.tspackages/web/src/features/chat/components/chatThread/answerCard.tsxpackages/web/src/app/api/(server)/chat/route.ts
✅ Files skipped from review due to trivial changes (1)
- .github/workflows/_gcp-deploy.yml
🚧 Files skipped from review as they are similar to previous changes (5)
- packages/web/package.json
- packages/web/src/features/chat/agent.ts
- packages/web/src/features/chat/components/chatThread/chatThreadListItem.tsx
- packages/web/src/features/chat/types.ts
- packages/web/src/env.mjs
🧰 Additional context used
📓 Path-based instructions (1)
**/*
📄 CodeRabbit Inference Engine (.cursor/rules/style.mdc)
Filenames should always be camelCase. Exception: if there are filenames in the same directory with a format other than camelCase, use that format to keep things consistent.
Files:
packages/web/src/instrumentation.tspackages/web/src/features/chat/components/chatThread/answerCard.tsxpackages/web/src/app/api/(server)/chat/route.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: build
🔇 Additional comments (5)
packages/web/src/instrumentation.ts (1)
7-16: LGTM! Clean conditional telemetry setup.The OpenTelemetry initialization is properly conditionally executed based on environment variable availability, preventing runtime errors when Langfuse isn't configured. The service name and configuration look appropriate for the chat feature integration.
packages/web/src/features/chat/components/chatThread/answerCard.tsx (4)
35-54: LGTM! Proper forwardRef implementation.The component properly uses forwardRef and useImperativeHandle to expose the internal markdown renderer ref. The props interface is well-structured.
56-63: LGTM! Clean clipboard functionality.The copy implementation properly converts the content to portable markdown and provides appropriate user feedback through toast notifications.
100-148: LGTM! Well-structured UI layout.The component structure is well-organized with proper conditional rendering, sticky positioning, and accessibility features through tooltips.
157-183: LGTM! Proper feedback button implementation.The feedback buttons have appropriate disabled states, visual feedback through variants, and prevent multiple submissions. The component ends with proper displayName for debugging.
packages/web/src/features/chat/components/chatThread/answerCard.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (1)
packages/web/src/features/chat/components/chatThread/answerCard.tsx (1)
90-94: Add conditional checks for Langfuse scoring.The Langfuse scoring doesn't validate that
traceIdis provided or that the LangfuseWeb instance is properly initialized.- langfuseWeb?.score({ - traceId: traceId, - name: 'user_feedback', - value: feedbackType === 'like' ? 1 : 0, - }) + if (traceId && langfuseWeb) { + try { + langfuseWeb.score({ + traceId: traceId, + name: 'user_feedback', + value: feedbackType === 'like' ? 1 : 0, + }); + } catch (error) { + console.warn('Failed to submit Langfuse score:', error); + } + }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
packages/web/src/app/[domain]/components/homepage/toolbar.tsx(1 hunks)packages/web/src/app/layout.tsx(1 hunks)packages/web/src/features/chat/components/chatThread/answerCard.tsx(1 hunks)packages/web/src/features/chat/components/chatThread/chatThread.tsx(1 hunks)packages/web/src/lib/newsData.ts(1 hunks)
📓 Path-based instructions (1)
**/*
📄 CodeRabbit Inference Engine (.cursor/rules/style.mdc)
Filenames should always be camelCase. Exception: if there are filenames in the same directory with a format other than camelCase, use that format to keep things consistent.
Files:
packages/web/src/features/chat/components/chatThread/answerCard.tsx
🧬 Code Graph Analysis (1)
packages/web/src/features/chat/components/chatThread/answerCard.tsx (11)
packages/web/src/env.mjs (2)
env(14-147)env(14-147)packages/web/src/features/chat/useTOCItems.ts (1)
useExtractTOCItems(17-100)packages/web/src/features/chat/utils.ts (1)
convertLLMOutputToPortableMarkdown(243-258)packages/web/src/features/chat/actions.ts (1)
submitFeedback(214-268)packages/web/src/features/chat/components/chatThread/tableOfContents.tsx (1)
TableOfContents(19-54)packages/web/src/components/ui/tooltip.tsx (3)
Tooltip(30-30)TooltipTrigger(30-30)TooltipContent(30-30)packages/web/src/app/[domain]/components/copyIconButton.tsx (1)
CopyIconButton(13-39)packages/web/src/components/ui/toggle.tsx (1)
Toggle(45-45)packages/web/src/components/ui/separator.tsx (1)
Separator(31-31)packages/web/src/features/chat/components/chatThread/markdownRenderer.tsx (1)
MarkdownRenderer(101-217)packages/web/src/components/ui/button.tsx (1)
Button(56-56)
✅ Files skipped from review due to trivial changes (2)
- packages/web/src/app/layout.tsx
- packages/web/src/lib/newsData.ts
🚧 Files skipped from review as they are similar to previous changes (2)
- packages/web/src/app/[domain]/components/homepage/toolbar.tsx
- packages/web/src/features/chat/components/chatThread/chatThread.tsx
🧰 Additional context used
📓 Path-based instructions (1)
**/*
📄 CodeRabbit Inference Engine (.cursor/rules/style.mdc)
Filenames should always be camelCase. Exception: if there are filenames in the same directory with a format other than camelCase, use that format to keep things consistent.
Files:
packages/web/src/features/chat/components/chatThread/answerCard.tsx
🧬 Code Graph Analysis (1)
packages/web/src/features/chat/components/chatThread/answerCard.tsx (11)
packages/web/src/env.mjs (2)
env(14-147)env(14-147)packages/web/src/features/chat/useTOCItems.ts (1)
useExtractTOCItems(17-100)packages/web/src/features/chat/utils.ts (1)
convertLLMOutputToPortableMarkdown(243-258)packages/web/src/features/chat/actions.ts (1)
submitFeedback(214-268)packages/web/src/features/chat/components/chatThread/tableOfContents.tsx (1)
TableOfContents(19-54)packages/web/src/components/ui/tooltip.tsx (3)
Tooltip(30-30)TooltipTrigger(30-30)TooltipContent(30-30)packages/web/src/app/[domain]/components/copyIconButton.tsx (1)
CopyIconButton(13-39)packages/web/src/components/ui/toggle.tsx (1)
Toggle(45-45)packages/web/src/components/ui/separator.tsx (1)
Separator(31-31)packages/web/src/features/chat/components/chatThread/markdownRenderer.tsx (1)
MarkdownRenderer(101-217)packages/web/src/components/ui/button.tsx (1)
Button(56-56)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: build
🔇 Additional comments (6)
packages/web/src/features/chat/components/chatThread/answerCard.tsx (6)
1-28: LGTM: Clean imports and well-typed interface.The imports are well-organized and the
AnswerCardPropsinterface properly defines all required and optional properties with appropriate TypeScript types.
30-33: Langfuse client initialization looks good.The conditional instantiation based on environment variables is appropriate and follows good practices for optional third-party integrations.
35-54: LGTM: Proper ref forwarding and state management.The component setup correctly uses
forwardRefanduseImperativeHandleto expose the internal markdown renderer's DOM node, which is essential for the TOC functionality.
56-63: LGTM: Well-implemented copy functionality.The copy callback properly converts the content to portable markdown and provides appropriate user feedback via toast notifications.
100-180: LGTM: Well-structured UI with good UX patterns.The render method implements a clean layout with appropriate conditional rendering, sticky headers, tooltips for accessibility, and proper button state management.
183-183: LGTM: Proper displayName for debugging.Setting the displayName is good practice for components using
forwardRefto aid in debugging and development tools.
packages/web/src/features/chat/components/chatThread/answerCard.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Actionable comments posted: 0
♻️ Duplicate comments (1)
README.md (1)
52-52: Replace bare URL with markdown image syntaxThis bare URL still violates MD034. Convert it to an image (or regular link) as previously suggested.
-https://github.com/user-attachments/assets/286ad97a-a543-4eef-a2f1-4fa31bea1b32 +
🧹 Nitpick comments (1)
README.md (1)
49-49: Fix subject–verb agreement (“provide” → “provides”)
Sourcebotis singular, so the sentence should read “Sourcebot provides detailed answers …”.- - **Ask Sourcebot:** Ask questions about your codebase and have Sourcebot provide detailed answers grounded with inline citations. + - **Ask Sourcebot:** Ask questions about your codebase and have Sourcebot provides detailed answers grounded with inline citations.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
README.md(1 hunks)
📓 Path-based instructions (1)
**/*
📄 CodeRabbit Inference Engine (.cursor/rules/style.mdc)
Filenames should always be camelCase. Exception: if there are filenames in the same directory with a format other than camelCase, use that format to keep things consistent.
Files:
README.md
🧠 Learnings (1)
README.md (1)
Learnt from: drew-u410
PR: #328
File: CONTRIBUTING.md:5-5
Timestamp: 2025-06-03T00:22:00.498Z
Learning: In the sourcebot repository CONTRIBUTING.md file, the maintainer prefers using "NodeJS" spelling instead of the official "Node.js" branding, and prefers not to add alt text to favicon images in the installation instructions.
🪛 markdownlint-cli2 (0.17.2)
README.md
52-52: Bare URL used
(MD034, no-bare-urls)
🧰 Additional context used
📓 Path-based instructions (1)
**/*
📄 CodeRabbit Inference Engine (.cursor/rules/style.mdc)
Filenames should always be camelCase. Exception: if there are filenames in the same directory with a format other than camelCase, use that format to keep things consistent.
Files:
README.md
🧠 Learnings (1)
README.md (1)
Learnt from: drew-u410
PR: #328
File: CONTRIBUTING.md:5-5
Timestamp: 2025-06-03T00:22:00.498Z
Learning: In the sourcebot repository CONTRIBUTING.md file, the maintainer prefers using "NodeJS" spelling instead of the official "Node.js" branding, and prefers not to add alt text to favicon images in the installation instructions.
🪛 markdownlint-cli2 (0.17.2)
README.md
52-52: Bare URL used
(MD034, no-bare-urls)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: build
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (7)
docs/docs/features/ask/overview.mdx (2)
25-32: Add accessible fallback text for the embedded video.The
<video>element lacks a descriptive fallback (<track>captions or a surrounding<figcaption>). This is required for keyboard / screen-reader users and WCAG compliance.-<video +<figure> +<video autoPlay muted loop playsInline className="w-full aspect-video" src="/images/ask_sourcebot_low_res.mp4" ></video> +<figcaption>Demonstration of Ask Sourcebot answering questions with inline citations.</figcaption> +</figure>
45-45: Possessive apostrophe missing.“teams entire codebase” → “team’s entire codebase”.
-Ask questions about your teams entire codebase +Ask questions about your team’s entire codebasedocs/docs/configuration/language-model-providers.mdx (3)
116-116: Spelling: “paramater” → “parameter”.Minor typo in the Note block.
-`credentials` paramater +`credentials` parameter
141-141: Spelling: “paramater” → “parameter”.Same typo appears again.
-`credentials` paramater +`credentials` parameter
14-24: JSON examples contain comments and will not validate as JSON.Because the fence is tagged
json, many copy/paste linters will error.
Usejsonc(JSON-with-comments) or drop the// …lines.-```json wrap icon="code" Example config with language model provider +```jsonc wrap icon="code" Example config with language model provider(Repeat for other blocks that include inline comments.)
docs/docs/connections/overview.mdx (2)
9-9: Add period after “etc.”American English requires the trailing period in abbreviations.
-GitHub, GitLab, etc) +GitHub, GitLab, etc.)
47-49: Grammar tweak: interval “has elapsed”, not “has exceeded”.Current phrasing is awkward.
-`resyncConnectionIntervalMs` ... has exceeded, the connection will be synced. +`resyncConnectionIntervalMs` ... has elapsed, the connection will be synced.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (16)
docs/docs.json(4 hunks)docs/docs/configuration/config-file.mdx(1 hunks)docs/docs/configuration/language-model-providers.mdx(1 hunks)docs/docs/connections/bitbucket-cloud.mdx(1 hunks)docs/docs/connections/bitbucket-data-center.mdx(1 hunks)docs/docs/connections/generic-git-host.mdx(1 hunks)docs/docs/connections/gerrit.mdx(1 hunks)docs/docs/connections/gitea.mdx(1 hunks)docs/docs/connections/github.mdx(1 hunks)docs/docs/connections/gitlab.mdx(1 hunks)docs/docs/connections/local-repos.mdx(1 hunks)docs/docs/connections/overview.mdx(2 hunks)docs/docs/deployment-guide.mdx(1 hunks)docs/docs/features/ask/add-model-providers.mdx(1 hunks)docs/docs/features/ask/overview.mdx(1 hunks)docs/docs/features/search/overview.mdx(1 hunks)
📓 Path-based instructions (1)
**/*
📄 CodeRabbit Inference Engine (.cursor/rules/style.mdc)
Filenames should always be camelCase. Exception: if there are filenames in the same directory with a format other than camelCase, use that format to keep things consistent.
Files:
docs/docs/configuration/language-model-providers.mdxdocs/docs/connections/overview.mdxdocs/docs/features/ask/overview.mdx
🪛 LanguageTool
docs/docs/configuration/language-model-providers.mdx
[grammar] ~116-~116: Ensure spelling is correct
Context: ... instead The credentials paramater here expects a path to a [credentia...
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
[grammar] ~141-~141: Ensure spelling is correct
Context: ...rtex Anthropic The credentials paramater here expects a path to a [credentia...
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
docs/docs/connections/overview.mdx
[style] ~9-~9: In American English, abbreviations like “etc.” require a period.
Context: ...o a code host platform (GitHub, GitLab, etc). Connections are defined within the [c...
(ETC_PERIOD)
docs/docs/features/ask/overview.mdx
[style] ~51-~51: Consider using a less common alternative to make your writing sound more unique and professional.
Context: ...eful. We'd love to know what you think! Feel free to join the discussion on our [GitHub](htt...
(FEEL_FREE_TO_STYLE_ME)
✅ Files skipped from review due to trivial changes (11)
- docs/docs/connections/local-repos.mdx
- docs/docs/connections/generic-git-host.mdx
- docs/docs/connections/gerrit.mdx
- docs/docs/connections/bitbucket-cloud.mdx
- docs/docs/connections/gitea.mdx
- docs/docs/deployment-guide.mdx
- docs/docs/features/ask/add-model-providers.mdx
- docs/docs/connections/gitlab.mdx
- docs/docs/connections/bitbucket-data-center.mdx
- docs/docs/configuration/config-file.mdx
- docs/docs/connections/github.mdx
🚧 Files skipped from review as they are similar to previous changes (2)
- docs/docs/features/search/overview.mdx
- docs/docs.json
🧰 Additional context used
📓 Path-based instructions (1)
**/*
📄 CodeRabbit Inference Engine (.cursor/rules/style.mdc)
Filenames should always be camelCase. Exception: if there are filenames in the same directory with a format other than camelCase, use that format to keep things consistent.
Files:
docs/docs/configuration/language-model-providers.mdxdocs/docs/connections/overview.mdxdocs/docs/features/ask/overview.mdx
🪛 LanguageTool
docs/docs/configuration/language-model-providers.mdx
[grammar] ~116-~116: Ensure spelling is correct
Context: ... instead The credentials paramater here expects a path to a [credentia...
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
[grammar] ~141-~141: Ensure spelling is correct
Context: ...rtex Anthropic The credentials paramater here expects a path to a [credentia...
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
docs/docs/connections/overview.mdx
[style] ~9-~9: In American English, abbreviations like “etc.” require a period.
Context: ...o a code host platform (GitHub, GitLab, etc). Connections are defined within the [c...
(ETC_PERIOD)
docs/docs/features/ask/overview.mdx
[style] ~51-~51: Consider using a less common alternative to make your writing sound more unique and professional.
Context: ...eful. We'd love to know what you think! Feel free to join the discussion on our [GitHub](htt...
(FEEL_FREE_TO_STYLE_ME)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: build
🔇 Additional comments (1)
docs/docs/features/ask/overview.mdx (1)
7-8: Double-check link target for “code navigation”.
/docs/features/code-navigationdoes not exist elsewhere in the tree (other pages use/docs/features/navigation/overview). Broken links degrade docs UX.
|
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (7)
packages/web/src/features/chat/actions.ts (7)
26-26: Replace unsafe type casting with proper type validationThis unsafe type casting bypasses TypeScript's type safety, as previously mentioned in past reviews. Consider using proper validation with a schema library like Zod.
57-57: Replace unsafe type casting with proper type validationThis unsafe type casting when retrieving messages bypasses TypeScript's type safety. Use proper validation when loading data from the database.
92-92: Replace unsafe type casting with proper type validationThis unsafe type casting when saving messages bypasses TypeScript's type safety. Validate the messages before saving to ensure data integrity.
96-104: Security concern: Validate file paths and add access controls for debug file writesThe debug file writing functionality lacks proper security controls as mentioned in past reviews:
- No validation that this is only enabled in development
- No sanitization of the chatId parameter
- Potential for path traversal attacks
242-242: Replace unsafe type casting with proper type validationMultiple unsafe type castings when loading and saving messages bypass TypeScript's type safety. Implement proper validation for both operations.
Also applies to: 263-263
290-302: Add error recovery for configuration loadingThe function silently returns an empty array on configuration errors, which could hide critical issues in production as mentioned in past reviews. Consider providing default configurations or throwing errors for critical failures.
189-193: Use appropriate ErrorCode for forbidden operationsThe error code
UNEXPECTED_ERRORdoesn't accurately represent a forbidden operation. Use a more specific error code likeINSUFFICIENT_PERMISSIONS.return { statusCode: StatusCodes.FORBIDDEN, - errorCode: ErrorCode.UNEXPECTED_ERROR, + errorCode: ErrorCode.INSUFFICIENT_PERMISSIONS, message: 'You are not allowed to delete this chat.', } satisfies ServiceError;
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
packages/web/src/app/api/(server)/chat/route.ts(1 hunks)packages/web/src/features/chat/actions.ts(1 hunks)packages/web/src/features/chat/components/chatThread/answerCard.tsx(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- packages/web/src/features/chat/components/chatThread/answerCard.tsx
🧰 Additional context used
📓 Path-based instructions (1)
**/*
📄 CodeRabbit Inference Engine (.cursor/rules/style.mdc)
Filenames should always be camelCase. Exception: if there are filenames in the same directory with a format other than camelCase, use that format to keep things consistent.
Files:
packages/web/src/features/chat/actions.tspackages/web/src/app/api/(server)/chat/route.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: build
🔇 Additional comments (3)
packages/web/src/features/chat/actions.ts (3)
112-133: Clean implementation of chat history retrievalThe function properly filters chats by user and organization, returns minimal necessary information, and avoids type casting issues present elsewhere.
135-171: Well-implemented chat name update with proper access controlsThe function correctly validates ownership, checks readonly status, and handles errors appropriately without type casting issues.
275-282: Good separation of concerns for client-safe dataThe function properly filters sensitive configuration data before sending to the client, following security best practices.
Ask Sourcebot
Ask questions about your codebase and have Sourcebot provide detailed answers grounded with inline citations.
hero_demo_v3_lowres.mp4
Key points:
@mentionsallow you to mention specific files for the LLM to include in it's context window.Summary by CodeRabbit
New Features
Enhancements
Bug Fixes / Style
CodeSnippetcomponent for consistency.Chores / Infrastructure
Database
Chatmodel with private/public visibility, read-only flag, message storage, and relations to users and organizations.ChatVisibilityenum withPRIVATEandPUBLICvalues.Documentation