-
-
Notifications
You must be signed in to change notification settings - Fork 12
Use cache directory to store build files #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
I am not very good at bash so please test it. Especially I am not sure about OS X recognition |
Thank you! Reviewing some background on your approach here and will document in the thread below. |
From Apple docs on
|
Do you know how broadly accepted / implemented the XDG spec is across Linux distros? Is this a Debian-specific issue or do applications commonly use this approach everywhere in Linux env's? |
From SO re portability of the
It looks like this may limit our shell support? Perhaps we go with a |
Yep, thanks for the docs. So we only store build cache files? If yes, this is the right place.
This thing should not be implemented by any distro. It it accepted by the most applications (and it's mostly accepted if it's specific linux only application). Here is a huge list of them: https://wiki.archlinux.org/title/XDG_Base_Directory (list is not full of course) -- here you can see programs and apps that do implement this spec, has workaround or has hardcoded path.
Not related to distro at all. I am using arch and void linux
Yep. I can provide example like alacritty UPDATE: I did some changes to the path in a commit above, check it again please |
`$HOME/Library/Caches` in macos (os x) `$XDG_CACHE_HOME/ttfautohint-build` (with fallback) in linux
26a1fb1
to
55e5a57
Compare
Thank you! I updated our CI tests to use GitHub Actions and rebased your changes here on the master branch updates so that we can run the tests. If everything passes, let's merge this and cut a new release with your updates. |
Mind updating the string check syntax fail in the shellcheck lint so that it passes POSIX sh tests? https://github.com/koalaman/shellcheck/wiki/SC2039#testing-equality See SO answer https://stackoverflow.com/a/1089852/2848172 for details. I think that the following syntax change in your if / else block may do the trick: if [ "$OS" = "Darwin"* ]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need some help converting from |
$HOME/Library/Caches
in macos (os x)$XDG_CACHE_HOME/ttfautohint-build
(with fallback) in linuxsolves #38