Skip to content

Fix float display to always show .0 for integer floats (closes #60) #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix float display to always show .0 for integer floats (closes #60) #63

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/stdlib.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1599,7 +1599,7 @@ export function toPythonFloat(num: number): string {
return num.toExponential().replace(/e([+-])(\d)$/, 'e$10$2');
}
if (Number.isInteger(num)) {
return num.toFixed(1).toString();
return num.toFixed(1);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't see how this can fix the bug. I agree that the toString is not needed and should be removed. But toFixed already produces a string, and toString will not change the string. So this change should be functionally neutral.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not too sure either here.

}
return num.toString();
}
Expand Down