Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show a non-empty chapter name for exception errors #27

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

cadappl
Copy link

@cadappl cadappl commented Dec 29, 2017

The first line of exceptions might be empty and an empty name will
be showed in the chapter. It's not good to know the actual error.

Add the check to use the first non-empty line instead as the chapter
name for exceptions.

The first line of exceptions might be empty and an empty name will
be showed in the chapter. It's not good to know the actual error.

Add the check to use the first non-empty line instead as the chapter
name for exceptions.
@cadappl
Copy link
Author

cadappl commented Dec 29, 2017

A sample exception could be:

12-27 16:59:13.422 2663 2691 E BluetoothMap:
12-27 16:59:13.422 2663 2691 E BluetoothMap: java.lang.IllegalArgumentException: Service not registered: android.bluetooth.BluetoothMap$2@e66b16b
12-27 16:59:13.422 2663 2691 E BluetoothMap: at android.app.LoadedApk.forgetServiceDispatcher(LoadedApk.java:1044)
12-27 16:59:13.422 2663 2691 E BluetoothMap: at android.app.ContextImpl.unbindService(ContextImpl.java:1340)
12-27 16:59:13.422 2663 2691 E BluetoothMap: at android.content.ContextWrapper.unbindService(ContextWrapper.java:616)
12-27 16:59:13.422 2663 2691 E BluetoothMap: at android.bluetooth.BluetoothMap$1.onBluetoothStateChange(BluetoothMap.java:64)
12-27 16:59:13.422 2663 2691 E BluetoothMap: at android.bluetooth.IBluetoothStateChangeCallback$Stub.onTransact(IBluetoothStateChangeCallback.java:55)
12-27 16:59:13.422 2663 2691 E BluetoothMap: at android.os.Binder.execTransact(Binder.java:453)

The first line is an empty one and no name will be showed on the left error chapter.

@cadappl cadappl closed this Dec 29, 2017
@cadappl cadappl reopened this Dec 29, 2017
Android Nougat starts supporting bugreportz to generate zipped
bugreport files. bugreport will print the warning at the beginning.

The change recognizes the lines and ignore them, then handle the
file in the old way.
It includes the changes:

- Return not to print more errors if bugreport isn't existed
- Replace colon in the source file name to make bugreport work
  in windows/cygwin to handle zip files.
A specific bugreport zip file will be generated and the change
can find out the bugreport file from main_entry.txt and only parse
it like other bugreport within a zip file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant