Skip to content

Conversation

@vikram-nexthop
Copy link

@vikram-nexthop vikram-nexthop commented Oct 8, 2025

  • include Control Plane POST.
  • CLI to fetch the POST status.

Implementation PRs:
sonic-net/sonic-buildimage#24067
sonic-net/sonic-swss#3907
sonic-net/sonic-wpa-supplicant#99

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@vikram-nexthop vikram-nexthop marked this pull request as ready for review October 8, 2025 05:40
@rlhui rlhui requested a review from ysmanman October 22, 2025 18:01
@judyjoseph
Copy link
Contributor

@vikram-nexthop Can you share more details on "Control Plane POST" ? I understand the SAI POST to check the ASIC/SecY -- but no so clear on the requirements on control plane POST

@vikram-nexthop
Copy link
Author

@judyjoseph Control plane POST validates the cryptographic module used by wpa_supplicant for MKA operations, which is separate from the SAI/ASIC crypto engines, and requires independent FIPS validation too.
Please see my clarification in PR #3907.

- Added sample MACsec POST status output for single and multi ASIC scenarios.
- Added CLI to ToC.
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

No pipelines are associated with this pull request.


The design must meet the following requirements:
- In order to accommodate different forwarding ASIC architecture or SAI implementation, the design should support enabling POST at either switch level (during switch init) or at MACSec engine level (during MACSec engine init).
- Should enable control plane POST at the MACSec level.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a must for FIPS compliance?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't say if it is a must(couldn't find a direct reference to control plane POST validation in the official FIPS documentation), but I do consider it necessary for SONiC MACsec FIPS compliance due to the following:

  1. These libraries (FIPS-certified OpenSSL FIPS Provider, SymCrypt) are not part of the SONiC repository but are critical to the security model - they handle authentication, data plane key generation, etc. Independent validation ensures their integrity and expected operational status (FIPS mode).
  2. Provides initialization-time detection of configuration errors, self-test failures, library corruption, etc enabling graceful service disabling rather than runtime failures.
  3. A one-time validation that reduces the attack surface by ensuring cryptographic libraries are in a known-good state.

This could prove redundant if the entire system (SONiC + 3rd party crypto libraries) is under a common FIPS boundary.

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

5 participants