-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][MIG] test_base_import_async: Migrate to version 16.0 #1
base: 16.0
Are you sure you want to change the base?
Conversation
98fde03
to
eafd46c
Compare
@sonhd91 : why I didn't see old commit histories of previous versions (< v15) in this PR ? |
This module already exists in OCA/queue/16.0 but not migrated version, so we don't need history commit in this PR |
lgtm |
sorry for interrupting, but if the migration is from 14.0 to 16.0, the commit OCA@1e2b3af should be preserved |
anh @dzungtran89 you meant we should preserve the commit history. Regrading the code, I didn't see much change except cleaning empty character |
I know, it's a part of a commit which was probably about doing pre-commit, but preserving commit history has its own meaning where we keep the commit history of a module, as well as respecting the contribution of the commit's author |
eafd46c
to
f9b297d
Compare
I just include the commit above, please check again |
thx, lgtm |
f9b297d
to
997d574
Compare
997d574
to
f731d47
Compare
Depended on(add test-requirements later):