Add SSH/SFTP backend #658
Merged
Add SSH/SFTP backend #658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
someone1
approved these changes
Feb 13, 2023
| @@ -94,7 +94,7 @@ func (f *FileBackend) Upload(ctx context.Context, vol *files.VolumeInfo) error { | |||
| _, err = io.Copy(w, vol) | |||
| if err != nil { | |||
| if closeErr := w.Close(); closeErr != nil { | |||
| log.AppLogger.Warningf("file backend: Error closing volume %s - %v", vol.ObjectName, err) | |||
| log.AppLogger.Warningf("file backend: Error closing volume %s - %v", vol.ObjectName, closeErr) | |||
|
Awesome, thanks for the merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this PR adds an ssh/sftp backend. I used the file backend as inspiration and just used the corresponding sftp client commands from github.com/pkg/sftp.
It also fixes a small bug in the file backend and adds a new line to the backup status message.
The ssh backend can be configured via multiple environment variables (see README.md) but by default tries to use common keys/config files from the users home directory.