Completed routes in frontend and server setup for login and register functionality #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for studentzynergy failed.
|
AmanSingh494
had a problem deploying
to
github-pages
GitHub Actions
Failure
github-actions
bot
added
bug
AmanSingh494
had a problem deploying
to
github-pages
GitHub Actions
Failure
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| body('email').isEmail().withMessage('Invalid email'), | ||
| body('password').notEmpty().withMessage('Password is required') | ||
| ], | ||
| register |
Check failure
Code scanning / CodeQL
Missing rate limiting High
| body('email').isEmail().withMessage('Invalid email'), | ||
| body('password').notEmpty().withMessage('Password is required') | ||
| ], | ||
| login |
Check failure
Code scanning / CodeQL
Missing rate limiting High
| ], | ||
| login | ||
| ) | ||
| router.post('/token', token) |
Check failure
Code scanning / CodeQL
Missing rate limiting High
AmanSingh494
had a problem deploying
to
github-pages
GitHub Actions
Failure
4darsh-Dev
approved these changes
Aug 7, 2024
There was a problem hiding this comment.
@AmanSingh494 ,
Few changes are required :
- add a rate limit when making call with database
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title:
Added routes in frontend and endpoints in backend
Description:
Configuration and setup of server and database. Created functions for sending request to server for login and signin
Related Issue:
Solves issue #36
Changes Made:
Backend -
-Server.js is the main file in the server
-server/db/index.js has db configurations for Postgre sql
-server/routes/auth.js has api endpoints for register, login and token renewal
-server/controllers/authControllers.js has logic for api endpoints
Environment Variables -
The server uses environment variables given below-
-PSQL Setup variables
PORT, PSQLPASSWORD, PSQLUSER, PSQLHOST, PSQLPORT, PSQLDATABASE
CLIENT_URL (frontend url for cors)
ACCESS_TOKEN_SECRET
REFRESH_TOKEN_SECRET
Frontend -
-config.js - contains backend url for requests
-api.js - contains requests functions for login, register
-login.js - function for sending user data to server on submit
-register.js - function for sending user data to server on submit
Checklist:
Please contact me in case of any bug or issue.