Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method AttributeSet#names to return array of all attribute names #379

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add method AttributeSet#names to return array of all attribute names #379

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
65393c0
Add method attribute_names to ClassMethods to collect all attributes …
tracyloisel Jun 23, 2017
38ebedf
add test for attribute_names in ClassMethods
tracyloisel Jun 23, 2017
4284445
mmove attribute_names to AttributeSet#names
tracyloisel Jun 23, 2017
7ee1fb5
fix typo
tracyloisel Jun 23, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions lib/virtus/attribute_set.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,23 @@ def initialize(parent = nil, attributes = [])
reset
end

# Returns all the attributes name defined on a Class
#
# @example
# class User
# include Virtus
#
# attribute :name, String
# attribute :age, Integer
# end
#
# @return [:name, :age]
#
# @api public
def names
@attributes.map(&:name)
end

# Iterate over each attribute in the set
#
# @example
Expand Down
6 changes: 6 additions & 0 deletions spec/unit/virtus/class_methods/finalize_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,12 @@ class Address
Virtus.finalize
end

describe 'attribute_names' do
it 'returns array of attribute names' do
expect(Examples::Person.attribute_set.names).to eq([:name, :articles, :address])
end
end

it "sets attributes that don't require finalization" do
expect(Examples::Person.attribute_set[:name]).to be_instance_of(Virtus::Attribute)
expect(Examples::Person.attribute_set[:name].primitive).to be(String)
Expand Down