Remove unused login column

app/models/spree/user.rb

@@ -26,8 +26,6 @@ def password=(new_password)
       super
     end
 
-    before_validation :set_login
-
     scope :admin, -> { includes(:spree_roles).where("#{Role.table_name}.name" => "admin") }
 
     def self.admin_created?
@@ -50,16 +48,10 @@ def password_required?
 
     private
 
-    def set_login
-      # for now force login to be same as email, eventually we will make this configurable, etc.
-      self.login ||= email if email
-    end
-
     def scramble_email_and_password
       return true if destroyed?
 
       self.email = SecureRandom.uuid + "@example.net"
-      self.login = email
       self.password = SecureRandom.hex(8)
       self.password_confirmation = password
       save

db/default/users.rb

@@ -40,8 +40,7 @@ def create_admin_user
   attributes = {
     password: password,
     password_confirmation: password,
-    email: email,
-    login: email
+    email: email
   }
 
   load 'spree/user.rb'

db/migrate/20210601202000_remove_login_from_spree_users.rb

@@ -0,0 +1,7 @@
+# frozen_string_literal: true
+
+class RemoveLoginFromSpreeUsers < SolidusSupport::Migration[5.1]
+  def change
+    remove_column(:spree_users, :login, :string)
+  end
+end