fix start dev server stream response#2148
Closed
jojo8356 wants to merge 2 commits into
Closed
Conversation
🦋 Changeset detectedLatest commit: 144ebf0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for solid-start-landing-page ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
What is the current behavior?
With the
@solidjs/vite-plugin-nitro-2setup, the dev server can return the literal string[object Object]for page requests instead of the rendered HTML.This happens because
stream.thenis deleted before theUSING_SOLID_START_DEV_SERVERbranch returns the Solid stream. h3 v2 then no longer treats the returned value as awaitable and handles it as a plain object body.Fixes #2145.
What is the new behavior?
The dev-server branch now returns the Solid stream with its thenable interface still intact, so h3 can await it and return the rendered HTML.
The
thenproperty is still removed before the TransformStream path, so the existing Cloudflare Workers behavior is unchanged.A regression test was added for the dev-server path.
Other information
Checked locally:
pnpm --filter @solidjs/start exec vitest run src/server/handler.spec.tspnpm --filter @solidjs/start buildBoth pass.
One unrelated note: the full
pnpm --filter @solidjs/start test:cirun currently fails onsrc/fns/handler.spec.ts, which imports./server-functions-handler.tsfrom the current checkout.