fix: rebuild navigation commitment on transition engine - #592
Merged
Conversation
…e reads Co-authored-by: Cursor <cursoragent@cursor.com>
🦋 Changeset detectedLatest commit: 8b3a8c2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Use Solid's canonical transition state so winning navigations settle before history commits without router-owned shadow lifecycle state. Co-authored-by: Cursor <cursoragent@cursor.com>
ryansolid
changed the title
sparklog
pushed a commit
to sparklog/solid-v2-todo
that referenced
this pull request
Aug 31, 2026
…solute-URL redirect workaround Upstream root-caused the silent relative-redirect failure: the commit-window dedupe in navigateFromRoute compared against a location read that can lag signal writes by a flush, so a soft navigation could be dropped as "already there" (solidjs/solid-router#592). Fixed in next.20 by rebuilding navigation commitment on the transition engine (single canonical location source, last-write-wins, history written after the winning transition). - @solidjs/router 2.0.0-next.19 -> 2.0.0-next.20. - Remove absoluteRedirectTarget (the same-origin absolute-URL workaround): login/register/logout are back to plain relative redirect('/'), which now navigates reliably. - Drop the helper's unit test; update the module doc comment. - Verified in real headless Chrome on a workerd preview: login/register/ logout all navigate (relative Location: / on the masked 200), wrong password still renders the inline error. 52 tests green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the timing-sensitive navigation drop reported in solidjs/solid#3107 by making Solid's transition engine the single source of truth for router navigation.
Test plan
pnpm test— 394 client tests, 33 server tests, and type tests pass against published Solid 2.0.0-rc.4.pnpm buildpasses.