Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add image section to trial details page #5337

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Conversation

bm743
Copy link
Contributor

@bm743 bm743 commented Feb 20, 2025

Description

Adds an image section to the trial details page that displays all of the images from every plot associated with the trial

Closes #5276

Checklist

  • Refactoring only
  • Documentation only
  • Fixture update only
  • Bug fix
    • The relevant issue has been closed.
    • Further work is required.
  • New feature
    • Relevant tests have been created and run.
    • Data was added to the fixture
      • Data was added via a patch in /t/data/fixture/patches/.
    • User-Facing Change
      • The user manual in /docs has been updated.
    • Any new Perl has been documented using perldoc.
    • Any new JavaScript has been documented using JSDoc.
    • Any new legacy JavaScript has been moved from /js to /js/source/legacy.

@lukasmueller
Copy link
Member

add accession name to table, make images a bit larger, allow sorting by columns

@ryan-preble
Copy link
Contributor

I was not able to get this to run on cassava-devel. Tried two different trials and both hung on opening the trial images tab. Eventually got a javascript warning:
image
Also got a bunch of errors in the javascript console, but I am not sure they are related to this branch at all.

For reference, the two trials I tried to view (and I do not know that they have images at all): trial ID 541 and trial ID 1228

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a section to the trial detail page that contains all the images taken on the trial
3 participants