Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove duplicate key from sgn.conf (brapi_require_login) #5327

Merged
merged 1 commit into from
Feb 17, 2025
Merged

remove duplicate key from sgn.conf (brapi_require_login) #5327

merged 1 commit into from
Feb 17, 2025

Conversation

lukasmueller
Copy link
Member

Description

The brapi_require_login config key is duplicated in sgn.conf which may cause issues

Checklist

  • Refactoring only
  • Documentation only
  • Fixture update only
  • Bug fix
    • The relevant issue has been closed.
    • Further work is required.
  • New feature
    • Relevant tests have been created and run.
    • Data was added to the fixture
      • Data was added via a patch in /t/data/fixture/patches/.
    • User-Facing Change
      • The user manual in /docs has been updated.
    • Any new Perl has been documented using perldoc.
    • Any new JavaScript has been documented using JSDoc.
    • Any new legacy JavaScript has been moved from /js to /js/source/legacy.

@chris263 chris263 self-requested a review February 17, 2025 14:34
chris263
chris263 approved these changes Feb 17, 2025
View reviewed changes
Copy link
Contributor

@chris263 chris263 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:-)

@lukasmueller lukasmueller requested a review from bm743 February 17, 2025 16:06
bm743
bm743 approved these changes Feb 17, 2025
View reviewed changes
Copy link
Contributor

@bm743 bm743 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lukasmueller lukasmueller merged commit 9effc4b into master Feb 17, 2025
3 checks passed
@lukasmueller lukasmueller deleted the topic/fix_sgn_conf branch February 17, 2025 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris263 chris263 chris263 approved these changes

@bm743 bm743 bm743 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lukasmueller @chris263 @bm743