Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the download format of the Entry List xlsx file. #5326

Merged
merged 5 commits into from
Feb 19, 2025

Conversation

lukasmueller
Copy link
Member

@lukasmueller lukasmueller commented Feb 13, 2025

Description

The entry number file that can be downloaded from the trial detail page is an xlsx file, but was erroneously coded as being xls. This led to strange errors when opening the file in Excel.

This pull request adjusts the file format to the correct xlsx format.

It also adds the ability to delete the entry numbers from the trial, for curators.

fixes #5325

Checklist

  • Refactoring only
  • Documentation only
  • Fixture update only
  • Bug fix
    • The relevant issue has been closed.
    • Further work is required.
  • New feature
    • Relevant tests have been created and run.
    • Data was added to the fixture
      • Data was added via a patch in /t/data/fixture/patches/.
    • User-Facing Change
      • The user manual in /docs has been updated.
    • Any new Perl has been documented using perldoc.
    • Any new JavaScript has been documented using JSDoc.
    • Any new legacy JavaScript has been moved from /js to /js/source/legacy.

@lukasmueller lukasmueller changed the title fix the download format of the xlsx file. fix the download format of the Entry List xlsx file. Feb 13, 2025
@dwaring87 dwaring87 self-requested a review February 17, 2025 15:39
@lukasmueller lukasmueller merged commit 498fb6b into master Feb 19, 2025
4 checks passed
@lukasmueller lukasmueller deleted the topic/fix_entry_number_file_format branch February 19, 2025 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Entry numbers issue
3 participants