Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Topic/change analysis upload requirements #5318

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Topic/change analysis upload requirements #5318

wants to merge 2 commits into from

Conversation

ryan-preble
Copy link
Contributor

Description

Removes requirement for supplemental files and a model to upload an analysis

#5311

Checklist

  • Refactoring only
  • Documentation only
  • Fixture update only
  • Bug fix
    • The relevant issue has been closed.
    • Further work is required.
  • New feature
    • Relevant tests have been created and run.
    • Data was added to the fixture
      • Data was added via a patch in /t/data/fixture/patches/.
    • User-Facing Change
      • The user manual in /docs has been updated.
    • Any new Perl has been documented using perldoc.
    • Any new JavaScript has been documented using JSDoc.
    • Any new legacy JavaScript has been moved from /js to /js/source/legacy.

chris263
chris263 approved these changes Feb 17, 2025
View reviewed changes
Copy link
Contributor

@chris263 chris263 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • It is taking a long time to load in large database because of refreshing materialized view. Would be possible to quickly finish the loading process and after that run refresh materialized view?
    I can not retrieve the analysis loaded. Filename is not defined. But I guess it is a different issue.
    Screenshot from 2025-02-17 09-31-46

@ryan-preble
Copy link
Contributor Author

  • It is taking a long time to load in large database because of refreshing materialized view. Would be possible to quickly finish the loading process and after that run refresh materialized view?
    I can not retrieve the analysis loaded. Filename is not defined. But I guess it is a different issue.

I will take a look at it. These seem like separate issues but it is probably good to fix them now

@ryan-preble ryan-preble marked this pull request as draft February 17, 2025 15:17
@ryan-preble
Copy link
Contributor Author

  • It is taking a long time to load in large database because of refreshing materialized view. Would be possible to quickly finish the loading process and after that run refresh materialized view?
    I can not retrieve the analysis loaded. Filename is not defined. But I guess it is a different issue.

I will take a look at it. These seem like separate issues but it is probably good to fix them now

We should discuss this in lab meeting. These errors are happening on master for me and should probably get lumped into the other issue about updating analysis uploads/downloads in general

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris263 chris263 chris263 approved these changes

@isaak isaak Awaiting requested review from isaak

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryan-preble @chris263