Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display personalized homepage when logged in #5287

Merged
merged 32 commits into from
Feb 19, 2025
Merged

Display personalized homepage when logged in #5287

merged 32 commits into from
Feb 19, 2025

Conversation

lukasmueller
Copy link
Member

@lukasmueller lukasmueller commented Jan 29, 2025 •
edited
Loading

Description

fixes #5235

Requires changes in Bio::Chado::Schema to be updated

Checklist

  • Refactoring only
  • Documentation only
  • Fixture update only
  • Bug fix
    • The relevant issue has been closed.
    • Further work is required.
  • New feature
    • Relevant tests have been created and run.
    • Data was added to the fixture
      • Data was added via a patch in /t/data/fixture/patches/.
    • User-Facing Change
      • The user manual in /docs has been updated.
    • Any new Perl has been documented using perldoc.
    • Any new JavaScript has been documented using JSDoc.
    • Any new legacy JavaScript has been moved from /js to /js/source/legacy.

@lukasmueller
add an index page for logged in users.
e995923
@lukasmueller
start adding functions to retrieve recent activities for personalized…
970378a 
… homepage.
@lukasmueller
provide more info about the user to the personalized homepage.
5774426
@lukasmueller
add functions for the personalized homepage.
5c4bf48
@lukasmueller
add AJAX functions for retrieving recently modified data for personal…
fbd5279 
…ized homepage.
@lukasmueller
tweak index page for logged in users.
80709cd
@lukasmueller
make recently added accessions table work.
6d01928
@lukasmueller
make recenlty added accessions table work - addl file.
2f6ece9
@lukasmueller
add a config variable to activate personalized homepage.
cac870b
@lukasmueller
tweak appearance of personalized homepage. Fix an issue with Stock cr…
173bb54 
…eate date; note that this requires an update to Bio-Chado-Schema.
@lukasmueller
test for personalized homepage.
20aacb4
@lukasmueller
allow create_date to be undef as not all the stocks have create dates.
3167de1
@lukasmueller
fix some idents; use the CXGN::People::Roles module with the new corr…
5c82ccc 
…ect people schema accessor.
@lukasmueller
Fix accessor for CXGN::People::Roles object - it should be people_sch…
ebb51b6 
…ema of type CXGN::People::Schema, not bcs_schema of type Bio::Chado::Schema.
@lukasmueller
add some POD for new recently_added_* functions.
5340b68
@lukasmueller
change schema parameter from bcs_schema to people_schema in code that…
b11f4ee 
… uses CXGN::People::Roles.
@lukasmueller
change schema parameter from bcs_schema to people_schema in code that…
b44ca08 
… uses CXGN::People::Roles.
@lukasmueller
adapt tests to new people_schema parameter in CXGN::Stock::Roles.
5aa916b
@lukasmueller
add tests for the functions that detect recently modified or added tr…
7c9c9eb 
…ials and accessions.
@lukasmueller
remove unused package.
8be409e
@lukasmueller
Merge branch 'master' into topic/personalized_homepage
9fdac4b
@lukasmueller
fix suggestions by lint.
408318c
@lukasmueller
add missing parameter timestamp.
3a0d93f
@lukasmueller
add to fixture pod.
f0fb625
@lukasmueller
call clean_up_db() in a few tests that interfere with new tests in th…
c38901e 
…e Trial.t test.
@lukasmueller
remove role section.
cd45369
@lukasmueller
fix lint error (return with explicit undef)
0b85000
@afpowell afpowell requested review from ryan-preble and isaak February 3, 2025 16:11
@ryan-preble
Copy link
Contributor

ryan-preble commented Feb 3, 2025 •
edited
Loading

Logged in as curator on test fixture, tried switching recent activity view from day to week and got a JS error:
image
Console:
image
And localhost STDERR:
image

@lukasmueller
Copy link
Member Author

lukasmueller commented Feb 3, 2025 •
edited
Loading

Ryan - you need to update your local Bio::Chado::Schema repo (I just merged a new branch into it)

@ryan-preble
Copy link
Contributor

Ryan - you need to update your local Bio::Chado::Schema repo (I just merged a new branch into it)

Got it - working now. My only other suggestion is to change the "recent trials" page to reflect analyses vs trials. It is telling me that stored analyses are phenotyping trials

isaak
isaak approved these changes Feb 5, 2025
View reviewed changes
Copy link
Member

@isaak isaak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A suggestion: how about moving the recent activities tables to the profile page or recent_activities page? In the homepage or wherever they are redirected to after login, show a welcome message and a link to redirect them to the 'recent activities' page and let them view the recent activities there?

@lukasmueller
Copy link
Member Author

Fix issue with Analyses appearing as Phenotyping Trials in the trial section

@ryan-preble
Copy link
Contributor

image
This query gets field trials in association with an accession. It uses the cvterms to filter out stored analyses, which are stored as analysis_experiments. Playing around with it may help get you the distinction between trial and analysis you are looking for

@lukasmueller lukasmueller merged commit 71506b8 into master Feb 19, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isaak isaak isaak approved these changes

@ryan-preble ryan-preble ryan-preble approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

logged in users should see recent activity on homepage
3 participants
@lukasmueller @ryan-preble @isaak