Don't set the oper flags on client (#443)

Remove unused OPER_FLAGS logic in favor new priv system. It had rotted over time and was overlapping with PINGSENT
solanum-ircd · Jan 29, 2025 · 7289d45 · 7289d45
1 parent 4e89f66
commit 7289d45
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 5 deletions.
diff --git a/include/s_newconf.h b/include/s_newconf.h
@@ -140,8 +140,6 @@ extern void cluster_generic(struct Client *, const char *, int cltype,
 #define OPER_ENCRYPTED	0x00001
 #define OPER_NEEDSSL    0x80000
 
-#define OPER_FLAGS	0	 /* no oper privs in Client.flags/oper_conf.flags currently */
-
 #define IsOperConfEncrypted(x)	((x)->flags & OPER_ENCRYPTED)
 #define IsOperConfNeedSSL(x)	((x)->flags & OPER_NEEDSSL)
 

diff --git a/ircd/s_user.c b/ircd/s_user.c
@@ -1177,8 +1177,6 @@ user_mode(struct Client *client_p, struct Client *source_p, int parc, const char
 				if(MyConnect(source_p))
 				{
 					source_p->umodes &= ~ConfigFileEntry.oper_only_umodes;
-					source_p->flags &= ~OPER_FLAGS;
-
 					rb_dlinkFindDestroy(source_p, &local_oper_list);
 				}
 
@@ -1494,7 +1492,6 @@ oper_up(struct Client *source_p, struct oper_conf *oper_p)
 	SetExtendChans(source_p);
 	SetExemptKline(source_p);
 
-	source_p->flags |= oper_p->flags;
 	source_p->user->opername = rb_strdup(oper_p->name);
 	source_p->user->privset = privilegeset_ref(oper_p->privset);