-
Notifications
You must be signed in to change notification settings - Fork 46
Overhaul #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
robbiet480
wants to merge
47
commits into
sogko:master
Choose a base branch
from
robbiet480:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Overhaul #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se context, overally just make it more like google/go-github
….md, provide example implementations of basic auth, OAuth 1.0a and OAuth 2.0/JWT. Fix a little bug in decoding to Error.
…ops w/ correct types
|
I'm going to make a sacrifice to the open-source gods so that this PR is merged and that @robbiet480 becomes the new maintainer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Big update, lots and lots of little changes to bring this library up to the latest WordPress API standards. Here's a list:
contextgorequestwithnet/http(for context and fixing weird query string edge cases)Thanks @dannynash @o1egl for your work on this!
@sogko I'm hoping you can accept this pull request and possibly transfer ownership of the repo to me. I'm building a whole business on top of go-wordpress, so I expect to be a maintainer of it for a long time to come.
Thanks all!