Implement basic support for doubles. #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implements operations such as +-* (though note that Doubles don't implement '/' in SOM!) but not comparisons (as we really need to improve some of our other support before it's worth fixing doubles) and many other necessary operations. However, it does largely integrate Doubles into the internal type system.
|
bors try |
tryBuild succeeded |
ptersilie
approved these changes
Sep 30, 2019
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Sep 30, 2019
47: Implement basic support for doubles. r=ptersilie a=ltratt This implements operations such as `+-*` (though note that Doubles don't implement `/` in SOM!) but not comparisons (as we really need to improve some of our other support before it's worth fixing doubles) and many other necessary operations. However, it does largely integrate Doubles into the internal type system. Note that this PR starts to diverge from SOM for minor reasons over formatting of doubles (SOM-st/SOM#22) and inconsistencies in Java SOM (at least) (SOM-st/SOM#20). Hopefully we will be able to fix that divergence at some point. Co-authored-by: Laurence Tratt <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements operations such as
+-*(though note that Doubles don't implement/in SOM!) but not comparisons (as we really need to improve some of our other support before it's worth fixing doubles) and many other necessary operations. However, it does largely integrate Doubles into the internal type system.Note that this PR starts to diverge from SOM for minor reasons over formatting of doubles (SOM-st/SOM#22) and inconsistencies in Java SOM (at least) (SOM-st/SOM#20). Hopefully we will be able to fix that divergence at some point.