This repository was archived by the owner on Aug 24, 2019. It is now read-only.
Update to Swift 4.1 #24
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
OK, this may not be ready for prime time yet. I hooked it up to an text editor today and things to not look right. I think some more testing is in order. Please hold off on merging it for the moment. |
Author
|
Well, that's embarrassing! I guess I should have read through the other PRs. I turns out that #18 addresses all the issues I was having and more. So, closing this PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated to Swift 4.1. Compiles with no errors or warnings on Xcode 9.3 (9E145). All tests passing.
In addition to source changes the project has been updated to recommended settings.
I noticed the dependency on X.framework is missing from the podspec, but my podspec knowledge is a bit rusty so I did not try to fix this.