Skip to content

Feature/support custom group name on nacos #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Feature/support custom group name on nacos #84

wants to merge 10 commits into from

Conversation

ChangedenCZD
Copy link
Contributor

No description provided.

@mansonchor
Copy link
Contributor

补下单测吧

@mansonchor
Copy link
Contributor

还有文档和用法，什么场景下需要自定义 group name

@ChangedenCZD
Copy link
Contributor Author

还有文档和用法，什么场景下需要自定义 group name

好的

@ChangedenCZD ChangedenCZD mentioned this pull request Sep 28, 2021
Open
4 tasks
@ChangedenCZD
Copy link
Contributor Author

@mansonchor

@mansonchor
Copy link
Contributor

没明白为什么要多加一个字段，需求和场景是什么？

@ChangedenCZD
Copy link
Contributor Author

没明白为什么要多加一个字段，需求和场景是什么？

image

我们公司nacos中有些服务定义了分组名称（这是Java允许的），如果Node没有对齐就会报找不到Provider

@mansonchor
Copy link
Contributor

没明白为什么要多加一个字段，需求和场景是什么？

image

我们公司nacos中有些服务定义了分组名称（这是Java允许的），如果Node没有对齐就会报找不到Provider

纯粹是影响 registy 的寻址的？那 service 和 server 的改动是为什么？

@ChangedenCZD
Copy link
Contributor Author

没明白为什么要多加一个字段，需求和场景是什么？

image
我们公司nacos中有些服务定义了分组名称（这是Java允许的），如果Node没有对齐就会报找不到Provider

纯粹是影响 registy 的寻址的？那 service 和 server 的改动是为什么？

对齐，node也可以自定义groupName后发布provider

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChangedenCZD @mansonchor