Implement Response Information of the new Streaming API #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ioquatix
force-pushed
the
response-info-in-streaming
branch
from
f872481 to
281fad9
Compare
ioquatix
reviewed
Jan 23, 2025
ioquatix
pushed a commit
that referenced
this pull request
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Faraday v2.5.0, a new streaming API has been introduced which allows adapters to provide response information to the
on_callblock. Acknowledging that not all adapters will implement this change immediately, the adapter specification skipped the related tests in the initial release of this change. This PR implements the new adapter specification for async-http-faraday, including populating response information during streaming, resolving #48.This implementation updates
envwith a response marked unfinished immediately after the request, in the same way the "reference implementation" of the faraday-net_http adapter is doing it. Moreover, the streaming tests have been adapted to the adapter specification tests.Last, it assumes #47.
Types of Changes
Not sure if this can be considered a bug.
Contribution