Skip to content

Implement Response Information of the new Streaming API #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ebababi opened this issue Jan 22, 2025 · 1 comment
Closed

Implement Response Information of the new Streaming API #48

ebababi opened this issue Jan 22, 2025 · 1 comment
Milestone

Comments

@ebababi
Copy link
Contributor

ebababi commented Jan 22, 2025

With Faraday v2.5.0, a new streaming API has been introduced which allows adapters to provide response information to the on_call block. Acknowledging that not all adapters will implement this change immediately, the adapter specification skipped the related tests in the initial release of this change.

When async-http-faraday adapter implemented streaming with 38ec627 the response information part was not implemented. It seems that popular Faraday implementations now expect the streaming API to provide response information.

To adapt to the future specification requirement and accommodate the expectations of the implementations let's implement response information in streaming.

ebababi added a commit to ebababi/async-http-faraday that referenced this issue Jan 22, 2025
ioquatix pushed a commit to ebababi/async-http-faraday that referenced this issue Jan 23, 2025
ioquatix pushed a commit that referenced this issue Jan 23, 2025
* Implement response info in streaming API. (#48)
@ioquatix ioquatix added this to the v0.20.0 milestone Jan 23, 2025
@ioquatix
Copy link
Member

Released in v0.20.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants