Adding aggregated engagement tracking to snowplow.js #1290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for snowplow-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
TODOBefore this can be merged, a |
mscwilson
approved these changes
Aug 11, 2025
| @@ -43,6 +78,7 @@ const createTrackerConfig = (cookieName) => { | |||
| cookieDomain: `.${domain[1]}.${domain[0]}`, | |||
| cookieName, | |||
| cookieSameSite: 'Lax', | |||
| keepalive: true, | |||
There was a problem hiding this comment.
This is an important point. It uses the keep alive functionality of the Fetch API that means even after a window is closed or you've navigated away, the browser will still complete the request. This was the problem with the Beacon API which made this entire aggregated page ping logic so flaky, and why I want to try this method out.
| @@ -64,16 +100,18 @@ const createTrackerConfig = (cookieName) => { | |||
| const setupBrowserTracker = () => { | |||
| newTracker( | |||
| 'snplow5', | |||
| 'https://collector.snowplow.io', | |||
| // 'https://collector.snowplow.io', | |||
There was a problem hiding this comment.
fix these commented out bits please
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.