fix: chromPeakSpectra,XcmsExperiment for updated MsExperiment #805
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, what I find weird is that R CMD check works with both the current version and also with your fix. |
|
It should be the MsExperiment package - for the BioC release you would need version >= 1.10.1 , for Bioc devel >= 1.11.1 what version do you have locally ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chromPeakSpectra()forXcmsExperimentobjects for MsExperiment package versions >= 1.10.1: don't report column (sample) names for the resultingXChromatograms(issue Check error on devel on all platforms [email protected] not equal to [email protected] #803, Build error on release on macOS, check error on Linux and Windows #804).