Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: filtering MsLevel for xic plot #741

Merged
merged 2 commits into from
Apr 22, 2024
Merged

fix: filtering MsLevel for xic plot #741

merged 2 commits into from
Apr 22, 2024

Conversation

NorStorz
Copy link
Contributor

jorainer
jorainer requested changes Apr 22, 2024
View reviewed changes
Copy link
Collaborator

@jorainer jorainer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @NorStorz ! Can you please also bump the version in the DESCRIPTION and add an entry in NEWS.md describing the change?

@sneumann
Copy link
Owner

Thanks @NorStorz , looks good now. Yours, Steffen

@sneumann sneumann merged commit 811b863 into sneumann:devel Apr 22, 2024
jorainer added a commit that referenced this pull request Jun 7, 2024
@jorainer
fix: add fix for plot,MsExperiment for LC-MS/MS data
3574486 
- Add the fix merged with PR #741 into the devel branch also to the release
  branch.
- The fix addresses the error generated when `plot,MsExperiment` is called on a
  `MsExperiment` with MS1 and MS2 spectra (issue #734).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorainer jorainer jorainer requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NorStorz @sneumann @jorainer