Skip to content

Commit

Permalink
win32: increase sound buffer to allow at least one frame (fixes #794)
Browse files Browse the repository at this point in the history
  • Loading branch information
@OV2
OV2 committed Mar 31, 2023
1 parent 0b5bad6 commit d29098c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion win32/win32_sound.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ bool ReInitSound()
S9xSoundOutput->DeInitSoundOutput();

last_volume = 1.0;
return S9xInitSound(0);
return S9xInitSound(25);
}

void CloseSoundDevice() {
Expand Down

6 comments on commit d29098c

@OV2
Copy link
Collaborator Author

@OV2 OV2 commented on d29098c Mar 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bearoso: the MINIMUM_BUFFER_SIZE in apu.cpp is only enough for one frame in NTSC, should we increase it? Then again different rates will require different minimum values. Maybe we simply specify the minimum in ms?

@bearoso
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The buffer size is always relative to the 32040 the SNES puts out, not the final resampled rate.

But increasing this won't hurt anything. The port is supposed to take all the audio every time the callback is called. If it's not ready, then it should either wait (sound sync) or just clear the buffer. So theoretically, it should only need a scanline's worth of buffer space. I'll have to look at the drivers and see why they're accumulating data.

@OV2
Copy link
Collaborator Author

@OV2 OV2 commented on d29098c Mar 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the formula in S9xInitSound then use a fixed rate?

The problem here was that avi recording only pulls samples after every frame, when it can write one complete video and audio frame. This worked for NTSC, but for PAL the buffer was smaller than the samples it tried to pull so it was always getting zeroes.

@xRavenXP
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello friends, how to use this and solve the problem of PAL game videos that are muted when being extracted from Snes9x?

@OV2
Copy link
Collaborator Author

@OV2 OV2 commented on d29098c Apr 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use the latest nightly, linked on the main repository page. For windows click on the corresponding job name, then on artifacts.

@xRavenXP
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I downloaded the build you made available, already with this problem of PAL games corrected. Thank you very much for making this correction. Now I can record PAL games without worrying.

Please sign in to comment.