sdsp: Check for invalid scale in defined way.

snes9xgit · Apr 30, 2023 · cbc14ee · cbc14ee
1 parent bc98b1d
commit cbc14ee
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/apu/bapu/dsp/SPC_DSP.cpp b/apu/bapu/dsp/SPC_DSP.cpp
@@ -672,9 +672,10 @@ inline void SPC_DSP::decode_brr( voice_t* v )
 
 		// Shift sample based on header
 		int const shift = header >> 4;
-		s = (s << shift) >> 1;
-		if ( shift >= 0xD ) // handle invalid range
-			s = (s >> 25) << 11; // same as: s = (s < 0 ? -0x800 : 0)
+		if (shift <= 12)
+			s = (s << shift) >> 1;
+		else
+			s &= 0x7ff;
 
 		// Apply IIR filter (8 is the most commonly used)
 		int const filter = header & 0x0C;