Skip to content

Conversation

MattMonk
Copy link
Collaborator

@MattMonk MattMonk commented Mar 19, 2025

The URL decorator function can be quite complicated (at least in my use-case) and is difficult to wrap into an expression that can be used in eval.

This PR changes instead to use a string which should be the entry point to a function defined somewhere else. This can then be imported and used within the class, e.g. url_decorator="apd.snakemake:url_decorator".

Additionally, the osx-64 platform is added to the list of possible platforms.

@MattMonk MattMonk self-assigned this Mar 19, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 19, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix_url

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@MattMonk MattMonk force-pushed the fix_url branch 3 times, most recently from 5e5fb15 to 1f04f02 Compare March 24, 2025 11:12
@MattMonk MattMonk changed the title fix!: Move URL decorator to use exec instead of eval fix!: Move URL decorator to use entry point instead of eval Sep 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant