Skip to content

fix: limit inventory by prefix #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 11, 2025
Merged

fix: limit inventory by prefix #43

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e659d2e
limit iterator by prefix
jakevc Mar 11, 2025
9704976
fix filter exclude no prefix dirname
jakevc Mar 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions snakemake_storage_plugin_s3/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

import boto3
import botocore.credentials
import os

from snakemake_interface_common.exceptions import WorkflowError
from snakemake_interface_storage_plugins.settings import StorageProviderSettingsBase
Expand Down Expand Up @@ -232,12 +233,14 @@ async def inventory(self, cache: IOCacheStorageInterface):
# bucket has been inventorized before, stop here
return

# check if bucket exists
if not self.bucket_exists():
cache.exists_in_storage[self.cache_key()] = False
else:
cache.exists_in_storage[self.get_inventory_parent()] = True
for obj in self.s3bucket().objects.all():
return

cache.exists_in_storage[self.get_inventory_parent()] = True
prefix = os.path.dirname(self.key)
if prefix:
for obj in self.s3bucket().objects.filter(Prefix=prefix):
key = self.cache_key(self._local_suffix_from_key(obj.key))
cache.mtime[key] = Mtime(storage=obj.last_modified.timestamp())
cache.size[key] = obj.size
Expand Down