Skip to content

Revert "Introduce generic fluent client generator to non-sdk codegen" #493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2021

Conversation

rcoh
Copy link
Collaborator

@rcoh rcoh commented Jun 11, 2021

Reverts awslabs/smithy-rs#463

Seeing weird stack overflow / infinite recursion issues:

    frame #8735: 0x000000010000bf01 ec2-helloworld`_$LT$T$u20$as$u20$smithy_client..erase..boxclone..CloneService$LT$Request$GT$$GT$::clone_box::h010c647f0a4ff9b5(self=0x0000000101e34380) at boxclone.rs:76:18
    frame #8736: 0x000000010000afb1 ec2-helloworld`_$LT$smithy_client..erase..boxclone..BoxCloneService$LT$T$C$U$C$E$GT$$u20$as$u20$core..clone..Clone$GT$::clone::hbe330dc7abb063d9(self=0x0000000101e34380) at boxclone.rs:115:20
    frame #8737: 0x000000010000bf01 ec2-helloworld`_$LT$T$u20$as$u20$smithy_client..erase..boxclone..CloneService$LT$Request$GT$$GT$::clone_box::h010c647f0a4ff9b5(self=0x0000000101e34380) at boxclone.rs:76:18
    frame #8738: 0x000000010000afb1 ec2-helloworld`_$LT$smithy_client..erase..boxclone..BoxCloneService$LT$T$C$U$C$E$GT$$u20$as$u20$core..clone..Clone$GT$::clone::hbe330dc7abb063d9(self=0x0000000101e34380) at boxclone.rs:115:20
    frame #8739: 0x000000010000bf01 ec2-helloworld`_$LT$T$u20$as$u20$smithy_client..erase..boxclone..CloneService$LT$Request$GT$$GT$::clone_box::h010c647f0a4ff9b5(self=0x0000000101e34380) at boxclone.rs:76:18
    frame #8740: 0x000000010000afb1 ec2-helloworld`_$LT$smithy_client..erase..boxclone..BoxCloneService$LT$T$C$U$C$E$GT$$u20$as$u20$core..clone..Clone$GT$::clone::hbe330dc7abb063d9(self=0x0000000101e34380) at boxclone.rs:C115:20

@rcoh rcoh requested a review from jdisanti June 11, 2021 16:14
@rcoh rcoh merged commit 5da03af into main Jun 11, 2021
@rcoh rcoh deleted the revert-463-generic-client branch June 11, 2021 16:19
@jonhoo
Copy link
Contributor

jonhoo commented Jun 11, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants