misc: upgrade to Dokka 2.0.0 #1284
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
Affected ArtifactsNo artifacts changed size |
ianbotsf
reviewed
May 19, 2025
| @@ -0,0 +1,30 @@ | |||
| import kotlin.text.set | |||
There was a problem hiding this comment.
Question: I like the idea of refactoring this out of the main build file. How much more work would it be to move it all the way out into aws-kotlin-repo-tools so that we had less duplication?
0marperez
reviewed
May 19, 2025
Comment on lines
-96
to
-101
| // Output subprojects' docs to <docs-base>/project-name/* instead of <docs-base>/path/to/project-name/* | ||
| // This is especially important for inter-repo linking (e.g., via externalDocumentationLink) because the | ||
| // package-list doesn't contain enough project path information to indicate where modules' documentation are | ||
| // located. | ||
| fileLayout.set { parent, child -> | ||
| parent.outputDirectory.dir(child.moduleName) |
There was a problem hiding this comment.
Does dokka handle this now or is the layout going to change?
Comment on lines
+77
to
79
| dependencies { | ||
| dokka(project(":runtime")) | ||
| } |
There was a problem hiding this comment.
Why do we need this now?
| * Ensure `navButton` elements are interactable and have proper accessibility properties | ||
| * Fixes accessibilty violation: "Ensure all interactive functionality is operable with the keyboard" | ||
| */ | ||
| function ensureNavButtonInteractable() { |
There was a problem hiding this comment.
Is this built-in in dokka 2?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
Description of changes
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.